Bigtop
  1. Bigtop
  2. BIGTOP-851

Typo breaks detection of multiple libraries in bigtop-utils in some JVMs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Simple typo in one of the recent patches to bigtop-utils. When locating requested libraries it overwrites the predicate instead of building it. I believe I missed this during initial testing because on some JVMs, all the requested libraries are in the same directory.

      1. BIGTOP-851.patch
        0.6 kB
        Sean Mackrory

        Activity

        Hide
        Johnny Zhang added a comment -

        @Sean, the fix looks straightforward. +1 for it.

        This reminds me that in Bigtop we may want to have a 'commit-test' to run before each patch checked in. Roman Shaposhnik, any thoughts?

        Show
        Johnny Zhang added a comment - @Sean, the fix looks straightforward. +1 for it. This reminds me that in Bigtop we may want to have a 'commit-test' to run before each patch checked in. Roman Shaposhnik , any thoughts?
        Hide
        Sean Mackrory added a comment -

        In this particular case a commit-test wouldn't have caught much, since this only manifests itself on some JVMs (and it works just fine for all the current uses in Bigtop). In general though, I'm always in favor of more automated testing.

        Show
        Sean Mackrory added a comment - In this particular case a commit-test wouldn't have caught much, since this only manifests itself on some JVMs (and it works just fine for all the current uses in Bigtop). In general though, I'm always in favor of more automated testing.
        Hide
        Johnny Zhang added a comment -

        thanks for clarification, I agree this kind of tests is tricky, at least it needs to be run on all supported platforms, otherwise cannot catch all issues. In this case, I guess the trunk tests http://bigtop01.cloudera.org:8080/view/Bigtop-trunk/ serves the purpose. Only thing is it catch it after being fact, but it is OK.

        Show
        Johnny Zhang added a comment - thanks for clarification, I agree this kind of tests is tricky, at least it needs to be run on all supported platforms, otherwise cannot catch all issues. In this case, I guess the trunk tests http://bigtop01.cloudera.org:8080/view/Bigtop-trunk/ serves the purpose. Only thing is it catch it after being fact, but it is OK.
        Hide
        Roman Shaposhnik added a comment -

        +1 and commited.

        Show
        Roman Shaposhnik added a comment - +1 and commited.

          People

          • Assignee:
            Sean Mackrory
            Reporter:
            Sean Mackrory
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development