Bigtop
  1. Bigtop
  2. BIGTOP-777

separate the Package Tests into service tests, file content tests, and dependency tests

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.0
    • Component/s: tests
    • Labels:
      None

      Description

      right now package test class TestPackagesPseudoDistributed.groovy mixes with package service tests, file contents tests and dependency tests. I am trying to use it to test the package and found there are too many failures in each run and very hard to isolate/verify the bugs and very hard to get a clean run to indicate certain level of health of the package.

      This patch is minor, but it will very helpful for me to isolate the package test issues in different levels (service, dependency, file contents) so that we can gradually get confident of our package before release.

      1. BIGTOP-777_1.patch
        12 kB
        Johnny Zhang
      2. BIGTOP-777.patch
        8 kB
        Johnny Zhang
      3. BIGTOP-777-alternative.txt
        7 kB
        Johnny Zhang
      4. BIGTOP-777.txt
        5 kB
        Johnny Zhang

        Activity

        Johnny Zhang created issue -
        Hide
        Roman Shaposhnik added a comment -

        sound like a good idea – looking forward for you patch!

        Show
        Roman Shaposhnik added a comment - sound like a good idea – looking forward for you patch!
        Johnny Zhang made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Johnny Zhang made changes -
        Attachment BIGTOP-777.txt [ 12552937 ]
        Hide
        Johnny Zhang added a comment -

        BIGTOP-777-alternative.txt and BIGTOP-777.txt both fine with me. I like BIGTOP-777-alternative.txt better, although it adds one more file

        Show
        Johnny Zhang added a comment - BIGTOP-777 -alternative.txt and BIGTOP-777 .txt both fine with me. I like BIGTOP-777 -alternative.txt better, although it adds one more file
        Johnny Zhang made changes -
        Attachment BIGTOP-777-alternative.txt [ 12552938 ]
        Hide
        Roman Shaposhnik added a comment -

        Patch looks good! Any chance you can resubmit it in git format-patch format so it is easier for me to apply?

        Show
        Roman Shaposhnik added a comment - Patch looks good! Any chance you can resubmit it in git format-patch format so it is easier for me to apply?
        Hide
        Johnny Zhang added a comment -

        sure 'BIGTOP-777.patch' is generated by git format-patch, does it looks right?

        Show
        Johnny Zhang added a comment - sure ' BIGTOP-777 .patch' is generated by git format-patch, does it looks right?
        Johnny Zhang made changes -
        Attachment BIGTOP-777.patch [ 12552948 ]
        Hide
        Johnny Zhang added a comment -

        Roman Shaposhnik, please see BIGTOP-777_1.patch which fix the email address and compilation error. It build find locally for me.

        Show
        Johnny Zhang added a comment - Roman Shaposhnik , please see BIGTOP-777 _1.patch which fix the email address and compilation error. It build find locally for me.
        Johnny Zhang made changes -
        Attachment BIGTOP-777_1.patch [ 12552960 ]
        Hide
        Roman Shaposhnik added a comment -

        +1 and commited!

        Show
        Roman Shaposhnik added a comment - +1 and commited!
        Roman Shaposhnik made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Roman Shaposhnik made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Johnny Zhang
            Reporter:
            Johnny Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development