Bigtop
  1. Bigtop
  2. BIGTOP-725

package service test TestServices should only do config once for a group of services

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.0
    • Component/s: Tests
    • Labels:
      None

      Description

      right now the package test TestServices.createState() use a loop to do config for each one of a group of services, for example. For HDFS services "hadoop-0.20-namenode", "hadoop-0.20-datanode", "hadoop-0.20-secondarynamenode", it do the same config three times

      12/10/02 13:34:41 TRACE shell.Shell: /bin/bash << __EOT__
      sed -i -e 's#<configuration>$#<configuration><property><name>dfs.safemode.min.datanodes</name><value>1</value></property><property><name>dfs.safemode.extension</name><value>0</value></property>#' /etc/hadoop/conf/hdfs-site.xml
      __EOT__
      12/10/02 13:34:41 TRACE shell.Shell: /bin/bash << __EOT__
      sed -i -e 's#<configuration>$#<configuration><property><name>dfs.safemode.min.datanodes</name><value>1</value></property><property><name>dfs.safemode.extension</name><value>0</value></property>#' /etc/hadoop/conf/hdfs-site.xml
      __EOT__
      12/10/02 13:34:41 TRACE shell.Shell: /bin/bash << __EOT__
      sed -i -e 's#<configuration>$#<configuration><property><name>dfs.safemode.min.datanodes</name><value>1</value></property><property><name>dfs.safemode.extension</name><value>0</value></property>#' /etc/hadoop/conf/hdfs-site.xml
      __EOT__
      

      it really just need to do it once

      1. BIGTOP_725.txt
        0.9 kB
        Johnny Zhang
      2. BIGTOP_725-1.txt
        0.9 kB
        Johnny Zhang

        Activity

        Hide
        Roman Shaposhnik added a comment -

        +1 and committed

        Show
        Roman Shaposhnik added a comment - +1 and committed
        Hide
        Johnny Zhang added a comment -

        with the patch, it only do config once

        12/10/02 17:26:58 TRACE shell.Shell: /bin/bash << __EOT__
        sed -i -e 's#<configuration>$#<configuration><property><name>dfs.safemode.min.datanodes</name><value>1</value></property><property><name>dfs.safemode.extension</name><value>0</value></property>#' /etc/hadoop/conf/hdfs-site.xml
        __EOT__
        
        Show
        Johnny Zhang added a comment - with the patch, it only do config once 12/10/02 17:26:58 TRACE shell.Shell: /bin/bash << __EOT__ sed -i -e 's#<configuration>$#<configuration><property><name>dfs.safemode.min.datanodes</name><value>1</value></property><property><name>dfs.safemode.extension</name><value>0</value></property>#' /etc/hadoop/conf/hdfs-site.xml __EOT__

          People

          • Assignee:
            Johnny Zhang
            Reporter:
            Johnny Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development