Bigtop
  1. Bigtop
  2. BIGTOP-638

move <services> block from common package_date.xml to each platform's (yum, apt, zypper) package_data.xml

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: 0.4.0
    • Component/s: Tests
    • Labels:
      None

      Description

      run TestPackagesPseudoDistributed in yum platform (like centos5_64), get several service test failures, due to manifest is incorrect, for example

      testPackageServices[flume-node](org.apache.bigtop.itest.packagesmoke.TestPackagesPseudoDistributed)  Time elapsed: 12.487 sec  <<< FAILURE!
      java.lang.AssertionError: wrong list of runlevels for service flume-node
      Expected: <[3=3, 2=2, 5=5, 4=4, ]>
           got: <{3=3, 4=4, 5=5}>
      
      1. BIGTOP-638-2.txt
        98 kB
        Johnny Zhang
      2. BIGTOP-638.txt
        97 kB
        Johnny Zhang

        Activity

        Hide
        Johnny Zhang added a comment -

        I suggest move the <services> block moved from bigtop-tests/test-artifacts/package/src/main/resources/package_date.xml to yum/pakcage_data.xml, apt/package_data.xml and zypper/package_date.xml

        since different platform family has different runlevel and oninstall status, putting <services> block in a common place will fail tests on certain platforms. take flume-node runlevel as example, it will pass in Debian, whose runlevel is 2,3,4,5, but will fail in yum, which is 3,4,5. The same apply to <oninstall>

        Show
        Johnny Zhang added a comment - I suggest move the <services> block moved from bigtop-tests/test-artifacts/package/src/main/resources/package_date.xml to yum/pakcage_data.xml, apt/package_data.xml and zypper/package_date.xml since different platform family has different runlevel and oninstall status, putting <services> block in a common place will fail tests on certain platforms. take flume-node runlevel as example, it will pass in Debian, whose runlevel is 2,3,4,5, but will fail in yum, which is 3,4,5. The same apply to <oninstall>
        Hide
        Johnny Zhang added a comment -

        change a better title

        Show
        Johnny Zhang added a comment - change a better title
        Hide
        Johnny Zhang added a comment -

        bump it to blocker since lots of package service tests will unless it is fixed

        Show
        Johnny Zhang added a comment - bump it to blocker since lots of package service tests will unless it is fixed
        Hide
        Roman Shaposhnik added a comment -

        Great suggestion, Johnny! Care to provide a patch?

        Show
        Roman Shaposhnik added a comment - Great suggestion, Johnny! Care to provide a patch?
        Hide
        Johnny Zhang added a comment -

        yeah! patch available very soon.

        Show
        Johnny Zhang added a comment - yeah! patch available very soon.
        Hide
        Johnny Zhang added a comment -

        patch is tested in centos5_64 and SLES11

        Show
        Johnny Zhang added a comment - patch is tested in centos5_64 and SLES11
        Hide
        Johnny Zhang added a comment - - edited

        the patche includes
        1. move <services> block from parent package_data.mxl to yum/apt/zypper/package_data.xml
        2. add <config> section for hbase-master and hadoop-yarn-proxyserver
        3. correct the <runlevel> and <oninstall> for each platform
        4. re-format the xml with "xmllint --format"

        Show
        Johnny Zhang added a comment - - edited the patche includes 1. move <services> block from parent package_data.mxl to yum/apt/zypper/package_data.xml 2. add <config> section for hbase-master and hadoop-yarn-proxyserver 3. correct the <runlevel> and <oninstall> for each platform 4. re-format the xml with "xmllint --format"
        Hide
        Roman Shaposhnik added a comment -

        Johnny, your patch doesn't seem to apply to cleanly on trunk. Please take a look on Mon.

        Show
        Roman Shaposhnik added a comment - Johnny, your patch doesn't seem to apply to cleanly on trunk. Please take a look on Mon.
        Hide
        Johnny Zhang added a comment -

        sorry about that, it is because bigtop-tests/test-artifacts/package/src/main/resources/package_data.xml is modified a little bit by other patch between I checkout and generating the patch. Will double check it working before submit in the future.

        please try this one (BIGTOP-638-2.txt), it should work now

        $ patch -p1 < BIGTOP-638-2.txt
        patching file bigtop-tests/test-artifacts/package/src/main/resources/apt/package_data.xml
        patching file bigtop-tests/test-artifacts/package/src/main/resources/package_data.xml
        patching file bigtop-tests/test-artifacts/package/src/main/resources/yum/package_data.xml
        patching file bigtop-tests/test-artifacts/package/src/main/resources/zypper/package_data.xml
        
        Show
        Johnny Zhang added a comment - sorry about that, it is because bigtop-tests/test-artifacts/package/src/main/resources/package_data.xml is modified a little bit by other patch between I checkout and generating the patch. Will double check it working before submit in the future. please try this one ( BIGTOP-638 -2.txt), it should work now $ patch -p1 < BIGTOP-638-2.txt patching file bigtop-tests/test-artifacts/package/src/main/resources/apt/package_data.xml patching file bigtop-tests/test-artifacts/package/src/main/resources/package_data.xml patching file bigtop-tests/test-artifacts/package/src/main/resources/yum/package_data.xml patching file bigtop-tests/test-artifacts/package/src/main/resources/zypper/package_data.xml
        Hide
        Roman Shaposhnik added a comment -

        +1 and commited! Thanks for the patch!

        Show
        Roman Shaposhnik added a comment - +1 and commited! Thanks for the patch!

          People

          • Assignee:
            Johnny Zhang
            Reporter:
            Johnny Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development