Bigtop
  1. Bigtop
  2. BIGTOP-574

Add netcat and fuser as dependencies for some of the Bigtop stack.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.4.0
    • Component/s: General
    • Labels:
      None

      Description

      The SshFenceByTcpPort class assumes that netcat (nc) and fuser will be available on the ssh target. fuser is in /sbin and is probably always installed, but I've definitely seen CentOS boxes without netcat installed. We could force installation by listing it as a package requirement, which I suspect would be a good thing.

      Relevant classes:

      hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceB
      hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceB
      hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceB
      hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceB
      hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/test/TestFuseDFS.java:
      hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/test/TestFuseDFS.java:
      hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/HDFSHighAvail

      1. BIGTOP-574.patch
        1 kB
        Peter Linnell
      2. BIGTOP-574-1.patch
        0.6 kB
        Peter Linnell

        Activity

        Hide
        Peter Linnell added a comment -

        This is the rpm patch

        Show
        Peter Linnell added a comment - This is the rpm patch
        Hide
        Peter Linnell added a comment -

        the Deb patch and both apply to trunk

        Show
        Peter Linnell added a comment - the Deb patch and both apply to trunk
        Hide
        Roman Shaposhnik added a comment -

        No sure why you need an extra set of dependencies for hadoop-mapreduce package. Just having them for hadoop should suffice.

        Show
        Roman Shaposhnik added a comment - No sure why you need an extra set of dependencies for hadoop-mapreduce package. Just having them for hadoop should suffice.
        Hide
        Peter Linnell added a comment -

        stricly speaking hadoop-mapreduce does not require hadoop or am i missing something

        Show
        Peter Linnell added a comment - stricly speaking hadoop-mapreduce does not require hadoop or am i missing something
        Hide
        Roman Shaposhnik added a comment -

        Well, there's a transitive dependency hadoop-mapreduce depends on hadoop-yarn and that depends on hadoop.

        Show
        Roman Shaposhnik added a comment - Well, there's a transitive dependency hadoop-mapreduce depends on hadoop-yarn and that depends on hadoop.
        Hide
        Peter Linnell added a comment -

        JIRA is busted, so here is the patch inlined.

        Index: hadoop/SPECS/hadoop.spec
        ===================================================================
        --- hadoop/SPECS/hadoop.spec    (revision 1338313)
        +++ hadoop/SPECS/hadoop.spec    (working copy)
        @@ -163,7 +163,7 @@
         Source23: hadoop-hdfs-zkfc.svc
         Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id} -u -n)
         BuildRequires: python >= 2.4, git, fuse-devel,fuse, automake, autoconf
        -Requires: coreutils, /usr/sbin/useradd, /usr/sbin/usermod, /sbin/chkconfig, /sbin/service, bigtop-utils, zookeeper >= 3.4.0
        +Requires: coreutils, /usr/sbin/useradd, /usr/sbin/usermod, /sbin/chkconfig, /sbin/service, bigtop-utils, zookeeper >= 3.4.0, fuser, netcat
         # Sadly, Sun/Oracle JDK in RPM form doesn't provide libjvm.so, which means we have
         # to set AutoReq to no in order to minimize confusion. Not ideal, but seems to work.
         # I wish there was a way to disable just one auto dependency (libjvm.so)
        
        Show
        Peter Linnell added a comment - JIRA is busted, so here is the patch inlined. Index: hadoop/SPECS/hadoop.spec =================================================================== --- hadoop/SPECS/hadoop.spec (revision 1338313) +++ hadoop/SPECS/hadoop.spec (working copy) @@ -163,7 +163,7 @@ Source23: hadoop-hdfs-zkfc.svc Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id} -u -n) BuildRequires: python >= 2.4, git, fuse-devel,fuse, automake, autoconf -Requires: coreutils, /usr/sbin/useradd, /usr/sbin/usermod, /sbin/chkconfig, /sbin/service, bigtop-utils, zookeeper >= 3.4.0 +Requires: coreutils, /usr/sbin/useradd, /usr/sbin/usermod, /sbin/chkconfig, /sbin/service, bigtop-utils, zookeeper >= 3.4.0, fuser, netcat # Sadly, Sun/Oracle JDK in RPM form doesn't provide libjvm.so, which means we have # to set AutoReq to no in order to minimize confusion. Not ideal, but seems to work. # I wish there was a way to disable just one auto dependency (libjvm.so)
        Hide
        Roman Shaposhnik added a comment -

        +1

        Show
        Roman Shaposhnik added a comment - +1
        Hide
        Peter Linnell added a comment -

        We need a different fix

        Show
        Peter Linnell added a comment - We need a different fix

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Peter Linnell
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development