Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: 0.4.0
    • Component/s: General
    • Labels:
      None
    1. BIGTOP-539.patch.txt
      9 kB
      Roman Shaposhnik

      Activity

      Hide
      Roman Shaposhnik added a comment -

      Guys, please review. The good news is that code seems to work. But there's a bit of things to settle – like what should the default for HA failover be and whether we should have 'enable' as an alias to one of the 'auto'/'manual' or whether we should just have 'auto'/'manual' and no 'enabled'

      Please chime in.

      Show
      Roman Shaposhnik added a comment - Guys, please review. The good news is that code seems to work. But there's a bit of things to settle – like what should the default for HA failover be and whether we should have 'enable' as an alias to one of the 'auto'/'manual' or whether we should just have 'auto'/'manual' and no 'enabled' Please chime in.
      Hide
      Peter Linnell added a comment -

      +1 LGTM

      I'm neutral on defaults.

      Show
      Peter Linnell added a comment - +1 LGTM I'm neutral on defaults.
      Hide
      Patrick Taylor Ramsey added a comment -

      +1

      Show
      Patrick Taylor Ramsey added a comment - +1
      Hide
      Konstantin Boudnik added a comment -

      I am running the recipes on Puppet 3.1.1 and it refuses to compile template code like
      <value><%= zookeeper_quorum %></value>
      However, this
      <value><%= $zookeeper_quorum %></value>
      works. Is it another case of backward "compatibility" in the Puppet?

      Show
      Konstantin Boudnik added a comment - I am running the recipes on Puppet 3.1.1 and it refuses to compile template code like <value><%= zookeeper_quorum %></value> However, this <value><%= $zookeeper_quorum %></value> works. Is it another case of backward "compatibility" in the Puppet?
      Hide
      Roman Shaposhnik added a comment -

      Cos, we need to * significantly* restructure our Puppet code. Here's the wiki with more details https://cwiki.apache.org/confluence/display/BIGTOP/Next+generation+Puppet+code+for+Bigtop+deployment

      I'm slowly working on this, but very slowly

      Show
      Roman Shaposhnik added a comment - Cos, we need to * significantly* restructure our Puppet code. Here's the wiki with more details https://cwiki.apache.org/confluence/display/BIGTOP/Next+generation+Puppet+code+for+Bigtop+deployment I'm slowly working on this, but very slowly
      Hide
      Konstantin Boudnik added a comment -

      Sure. But this is broken right now and I have put the patch for it into BIGTOP-275.patch

      Show
      Konstantin Boudnik added a comment - Sure. But this is broken right now and I have put the patch for it into BIGTOP-275 .patch
      Hide
      Roman Shaposhnik added a comment -

      This doesn't seem to apply cleaning on trunk. Is it supposed to go on top of another patch?

      Show
      Roman Shaposhnik added a comment - This doesn't seem to apply cleaning on trunk. Is it supposed to go on top of another patch?

        People

        • Assignee:
          Roman Shaposhnik
          Reporter:
          Roman Shaposhnik
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development