Bigtop
  1. Bigtop
  2. BIGTOP-510

log4j property must be set with property in for Flume NG pkg

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.3.0, 0.4.0
    • Component/s: General
    • Labels:
      None
    • Environment:

      [CentOS 5.7 64-bit]

      Description

      The /etc/flume-ng/log4j.properties file is configured by default to write to the current dir, which causes perms issues when the /etc/init.d/flume-ng-node daemon (running as user 'flume') attempts to write it. A fix would be to provide log4j.properties so that the property's value specifies /var/log/flume-ng as the log dir, like this:
      flume.log.dir=/var/log/flume-ng

      Thank you.

      1. BIGTOP-510.patch
        0.6 kB
        Bruno Mahé

        Activity

        Hide
        Mike Percy added a comment -

        Maybe we can just cd /var/log/flume-ng instead of replacing the file. I'm concerned about not being able to gracefully incorporate changes to the logger defaults across Flume releases if we do a complete replacement.

        Show
        Mike Percy added a comment - Maybe we can just cd /var/log/flume-ng instead of replacing the file. I'm concerned about not being able to gracefully incorporate changes to the logger defaults across Flume releases if we do a complete replacement.
        Hide
        Roman Shaposhnik added a comment -

        Wouldn't it be possible to parameterize log4j.properties upstream in such a way that it would allow overrides from the command line via -Dfoo=bar ? We do it for most of the components and it works fine without changing the content of the upstream file.

        Show
        Roman Shaposhnik added a comment - Wouldn't it be possible to parameterize log4j.properties upstream in such a way that it would allow overrides from the command line via -Dfoo=bar ? We do it for most of the components and it works fine without changing the content of the upstream file.
        Hide
        Bruno Mahé added a comment -

        Here is a patch.
        Tested locally the content is indeed modified and set to the right location

        Show
        Bruno Mahé added a comment - Here is a patch. Tested locally the content is indeed modified and set to the right location
        Hide
        Roman Shaposhnik added a comment -

        I really would like it to be fixed upstream and at least have a big fat FIXME in Bigtop's code

        otherwise looks good

        +1

        Show
        Roman Shaposhnik added a comment - I really would like it to be fixed upstream and at least have a big fat FIXME in Bigtop's code otherwise looks good +1
        Hide
        Bruno Mahé added a comment -

        Thanks!

        I will add a fixme before commiting this

        Show
        Bruno Mahé added a comment - Thanks! I will add a fixme before commiting this
        Hide
        Peter Linnell added a comment -

        +1 LGTM

        Show
        Peter Linnell added a comment - +1 LGTM

          People

          • Assignee:
            Bruno Mahé
            Reporter:
            Will McQueen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development