Bigtop
  1. Bigtop
  2. BIGTOP-502

Flume NG init script should pass --name "agent" instead of --name "<hostname>"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.3.0, 0.4.0
    • Fix Version/s: 0.4.0
    • Component/s: general
    • Labels:
      None
    • Environment:

      [CentOS 5.7 64-bit]

      Description

      The /etc/init.d/flume-ng-node init script currently passes this option:
      --name <hostname>
      ...to /usr/bin/flume-ng, but the option needs to be a constant name, "agent" (literally, w/o quotes), like this:
      --name agent

      The reason is because Flume NG currently can't properly parse a dot-separated hostname because dots are used as namepace delimiters. So instead we should probably hardcode it to the name "agent" as the default name of the agent (while still retaining the ability to specify a different node by specifying the FLUME_NODE_NAME).

      Thank you.

      1. BIGTOP-502.patch
        0.6 kB
        Bruno Mahé

        Activity

        Hide
        Bruno Mahé added a comment -

        Here is a patch

        Show
        Bruno Mahé added a comment - Here is a patch
        Hide
        Roman Shaposhnik added a comment -

        +1

        Show
        Roman Shaposhnik added a comment - +1
        Hide
        Peter Linnell added a comment -

        +1 LGTM

        Show
        Peter Linnell added a comment - +1 LGTM
        Hide
        Patrick Taylor Ramsey added a comment -

        Is there a reason that we're defaulting to a fixed string instead of somehow "cleaning up" the hostname (ie, by replacing the dots with dashes, or cut -d. -f1)?

        Show
        Patrick Taylor Ramsey added a comment - Is there a reason that we're defaulting to a fixed string instead of somehow "cleaning up" the hostname (ie, by replacing the dots with dashes, or cut -d. -f1)?
        Hide
        Roman Shaposhnik added a comment -

        I like ptr's suggestion. Any reason we shouldn't be doing it? Lets file a JIRA if it makes sense.

        Show
        Roman Shaposhnik added a comment - I like ptr's suggestion. Any reason we shouldn't be doing it? Lets file a JIRA if it makes sense.

          People

          • Assignee:
            Bruno Mahé
            Reporter:
            Will McQueen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development