Bigtop
  1. Bigtop
  2. BIGTOP-481

fix the way to handle repo key for Debian like system

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.4.0
    • Component/s: debian
    • Labels:
      None

      Description

      current bigtop package test for lucid doesn't import the key, hence the package installed is not authenticated.
      http://bigtop01.cloudera.org:8080/view/Bigtop-hadoop-0.23/job/Bigtop-hadoop-0.23-packagetest/label=lucid-slave/23/consoleFull
      search message "WARNING: The following packages cannot be authenticated!"

      1. BIGTOP-481_2.txt
        3 kB
        Johnny Zhang
      2. BIGTOP-481.txt
        4 kB
        Johnny Zhang

        Activity

        Hide
        Roman Shaposhnik added a comment -

        Thank a lot for the patch. A couple of things to note:

        1. please fix your indentation to follow whatever style we have (I believe its no TABS and two spaces for each level of indentation)
        2. the method signature has 3 arguments, but the implementation has 4. not sure what's happening there
        3. for the key==null it'll be easier to call an existing addBinRepo

        Looking forward to your new patch!

        Show
        Roman Shaposhnik added a comment - Thank a lot for the patch. A couple of things to note: please fix your indentation to follow whatever style we have (I believe its no TABS and two spaces for each level of indentation) the method signature has 3 arguments, but the implementation has 4. not sure what's happening there for the key==null it'll be easier to call an existing addBinRepo Looking forward to your new patch!
        Hide
        Roman Shaposhnik added a comment -

        btw, I added you to the project so that you can now assign JIRAs to yourself

        Show
        Roman Shaposhnik added a comment - btw, I added you to the project so that you can now assign JIRAs to yourself
        Hide
        Johnny Zhang added a comment -

        thanks for the comments, please look at 'BITTOP-481_2.txt'

        Show
        Johnny Zhang added a comment - thanks for the comments, please look at 'BITTOP-481_2.txt'
        Hide
        Roman Shaposhnik added a comment -

        This looks much better! +1 and should be committed shortly

        Show
        Roman Shaposhnik added a comment - This looks much better! +1 and should be committed shortly

          People

          • Assignee:
            Johnny Zhang
            Reporter:
            Johnny Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development