[BIGTOP-4064] Fix Bigtop toolchain to work with Puppet 3.x

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Component/s: toolchain
• Assignee: Masatake Iwasaki
• Reporter: Kengo Seki
• Created: 24/Feb/24 09:03
• Updated: 29/Feb/24 01:53
• Resolved: 29/Feb/24 01:53

Description

After merging BIGTOP-3991, building the CentOS 7 image fails as follows.

$ ./gradlew -POS=centos-7 bigtop-slaves

...

15.64 Error: Syntax error at '/'; expected ')' at /etc/puppet/modules/bigtop_toolchain/manifests/packages.pp:73 on node buildkitsandbox.flets-east.jp
15.64 Error: Syntax error at '/'; expected ')' at /etc/puppet/modules/bigtop_toolchain/manifests/packages.pp:73 on node buildkitsandbox.flets-east.jp
------
Dockerfile:22
--------------------
  21 |     
  22 | >>> RUN if [ -f ~/.bash_profile ]; then . ~/.bash_profile; fi && \
  23 | >>>     yum clean all && yum updateinfo && \
  24 | >>>     puppet apply -e "include bigtop_toolchain::installer" || if [ $? -ne 2 ]; then exit 1; fi
  25 |     COPY . /tmp/bigtop
--------------------
ERROR: failed to solve: process "/bin/sh -c if [ -f ~/.bash_profile ]; then . ~/.bash_profile; fi &&     yum clean all && yum updateinfo &&     puppet apply -e \"include bigtop_toolchain::installer\" || if [ $? -ne 2 ]; then exit 1; fi" did not complete successfully: exit code: 1

> Task :bigtop-slaves FAILED

FAILURE: Build failed with an exception.

I think the "in" operator and the "Integer" method introduced in that issue are not supported yet by Puppet 3.6, which is used in CentOS 7. seys iwasakims Would you fix it?

Issue Links

• is broken by: BIGTOP-3991 Add Rocky Linux 9 support
• links to: GitHub pull request #1238