Bigtop
  1. Bigtop
  2. BIGTOP-294

brp-repack-jars chokes on guice-2.0.jar because of the directories without any read permission

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      Sadly enough it feels like we need to disable brp-repack-jars since changing the artifact in Maven is not going to happen.

      1. BIGTOP-294-2.patch.txt
        3 kB
        Roman Shaposhnik
      2. BIGTOP-294.patch.txt
        1 kB
        Roman Shaposhnik

        Activity

        Roman Shaposhnik made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12644801 ] patch-available, re-open possible [ 12666031 ]
        Roman Shaposhnik made changes -
        Fix Version/s 0.4.0 [ 12318889 ]
        Roman Shaposhnik made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Bruno Mahé added a comment -
        Show
        Bruno Mahé added a comment - I opened http://code.google.com/p/google-guice/issues/detail?id=672 for upstream
        Hide
        Bruno Mahé added a comment - - edited
        • could you s/aspectjtools-1.6.5.jar/guice-<VERSION>/g please?
        • open an upstream ticket with guice
        Show
        Bruno Mahé added a comment - - edited could you s/aspectjtools-1.6.5.jar/guice-<VERSION>/g please? open an upstream ticket with guice
        Hide
        Roman Shaposhnik added a comment -

        New patch attached.

        Show
        Roman Shaposhnik added a comment - New patch attached.
        Roman Shaposhnik made changes -
        Attachment BIGTOP-294-2.patch.txt [ 12506308 ]
        Hide
        Peter Linnell added a comment -

        +1 LGTM

        Show
        Peter Linnell added a comment - +1 LGTM
        Hide
        Bruno Mahé added a comment -

        fair enough, it wasn't visible from the patch

        Show
        Bruno Mahé added a comment - fair enough, it wasn't visible from the patch
        Hide
        Roman Shaposhnik added a comment -

        On the condition not matching – it does match, since we're already in the !SuSE section, hence no need to test against it.

        Show
        Roman Shaposhnik added a comment - On the condition not matching – it does match, since we're already in the !SuSE section, hence no need to test against it.
        Hide
        Bruno Mahé added a comment -
        +# So I will suppose anything that is not Mageia or a SUSE will be a RHEL/CentOS/Fedora
        +%if %{!?mgaversion:1}0
        

        The comment does not match the condition

        Show
        Bruno Mahé added a comment - +# So I will suppose anything that is not Mageia or a SUSE will be a RHEL/CentOS/Fedora +%if %{!?mgaversion:1}0 The comment does not match the condition
        Hide
        Bruno Mahé added a comment -

        Notes on the patch:

        • Remove reference to CentOS5 it happens on other OSes
        • Please remove references to CDH
        Show
        Bruno Mahé added a comment - Notes on the patch: Remove reference to CentOS5 it happens on other OSes Please remove references to CDH
        Hide
        Bruno Mahé added a comment -

        Could we also open a ticket upstream and link it here?

        Show
        Bruno Mahé added a comment - Could we also open a ticket upstream and link it here?
        Roman Shaposhnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Roman Shaposhnik made changes -
        Field Original Value New Value
        Attachment BIGTOP-294.patch.txt [ 12506305 ]
        Roman Shaposhnik created issue -

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development