Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2801

charm race condition when gathering metrics

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.1
    • Component/s: deployment
    • Labels:
      None

      Description

      Some of the bigtop charms gather basic metrics about a deployment (e.g, number of datanodes, number of zookeeper peers, etc).

      In some cases, the metric collector may attempt to run before an application is ready. Update the metric yamls to only run the collection command if the charm is ready.

        Issue Links

          Activity

          Hide
          kwmonroe Kevin W Monroe added a comment -

          Verified linked PR fixes the resourcemanager charm. Merged and closing.

          Show
          kwmonroe Kevin W Monroe added a comment - Verified linked PR fixes the resourcemanager charm. Merged and closing.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/bigtop/pull/233

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/bigtop/pull/233
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kwmonroe opened a pull request:

          https://github.com/apache/bigtop/pull/233

          BIGTOP-2801: charm race condition when gathering metrics

          • only run the metric collector if the charm is ready.
          • drive by fix for the namenode; 8020 is used intra-cluster and doesn't need to be exposed.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/juju-solutions/bigtop bug/BIGTOP-2801/metric-when-ready

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/233.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #233


          commit a4c09e7366cf91bf0db4362b46581b79e978c2a6
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2017-06-07T16:24:18Z

          close namenode port

          commit 20e82d73f7b139917ed29f502d221c26ea077284
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2017-06-08T03:21:52Z

          do not collect metrics until the app is ready

          commit a7477e9921be6a3c1b9add622750c9b5be4d7700
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2017-06-08T04:50:05Z

          tweak command quotes


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kwmonroe opened a pull request: https://github.com/apache/bigtop/pull/233 BIGTOP-2801 : charm race condition when gathering metrics only run the metric collector if the charm is ready. drive by fix for the namenode; 8020 is used intra-cluster and doesn't need to be exposed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/juju-solutions/bigtop bug/ BIGTOP-2801 /metric-when-ready Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit a4c09e7366cf91bf0db4362b46581b79e978c2a6 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2017-06-07T16:24:18Z close namenode port commit 20e82d73f7b139917ed29f502d221c26ea077284 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2017-06-08T03:21:52Z do not collect metrics until the app is ready commit a7477e9921be6a3c1b9add622750c9b5be4d7700 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2017-06-08T04:50:05Z tweak command quotes

            People

            • Assignee:
              kwmonroe Kevin W Monroe
              Reporter:
              kwmonroe Kevin W Monroe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development