Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2778

Delete PermSize / MaxPermsize options, no longer support by Java 8

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.1
    • Component/s: build
    • Labels:
      None

      Description

      After upgrading Java to 8, there are warning messages like following:

      ......
      + export 'MAVEN_OPTS=-Xmx1500m -Xms1500m -XX:MaxPermSize=256m'
      + MAVEN_OPTS='-Xmx1500m -Xms1500m -XX:MaxPermSize=256m'
      + mvn -Divy.home=/var/lib/jenkins/.ivy2 -Dsbt.ivy.home=/var/lib/jenkins/.ivy2 -Duser.home=/var/lib/jenkins -Drepo.maven.org= -Dreactor.repo=file:///var/lib/jenkins/.m2/repository -Pscala-2.11 -Pbuild-distr -DskipTests clean package
      OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
      ......
      

      And the others:

      $ grep -r MaxPermSize ./
      .//bigtop-bigpetstore/bigpetstore-mapreduce/build.gradle:            jvmArgs '-XX:MaxPermSize=256m'
      .//bigtop-bigpetstore/bigpetstore-mapreduce/src/test/java/org/apache/bigtop/bigpetstore/generator/TestPetStoreTransactionGeneratorJob.java: * run this test with vm options -XX:MaxPermSize=256m -Xms512m -Xmx1024m
      .//bigtop-ci/jenkins/jobsCreator.groovy:// export JAVA_OPTS="-Xmx1536m -Xms256m -XX:MaxPermSize=256m"
      .//bigtop-ci/jenkins/jobsCreator.groovy:// export MAVEN_OPTS="-Xmx1536m -Xms256m -XX:MaxPermSize=256m"
      .//bigtop-packages/src/common/ambari/do-component-build:export _JAVA_OPTIONS="-Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true"
      .//bigtop-packages/src/common/apex/do-component-build:export MAVEN_OPTS="-XX:PermSize=1024m -XX:MaxPermSize=1024m"
      .//bigtop-packages/src/common/flume/do-component-build:export MAVEN_OPTS="-Xmx1536m -Xms256m -XX:MaxPermSize=256m"
      .//bigtop-packages/src/common/hama/do-component-build:export MAVEN_OPTS="-XX:PermSize=1024m -XX:MaxPermSize=1024m"
      .//bigtop-packages/src/common/hive/do-component-build:export MAVEN_OPTS="-Xmx1500m -Xms1500m -XX:MaxPermSize=256m"
      .//bigtop-packages/src/common/ignite-hadoop/do-component-build:export MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M"
      .//bigtop-packages/src/common/kafka/do-component-build:export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m -XX:PermSize=1024m -XX:MaxPermSize=1024m"
      .//bigtop-packages/src/common/oozie/do-component-build:export MAVEN_OPTS="-Xmx512m -XX:MaxPermSize=128m"
      .//bigtop-packages/src/common/spark1/do-component-build:export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m -XX:PermSize=1024m -XX:MaxPermSize=1024m"
      .//bigtop-packages/src/common/zeppelin/do-component-build:export MAVEN_OPTS="-Xmx1500m -Xms1500m -XX:MaxPermSize=256m"
      .//bigtop-packages/src/common/zeppelin/zeppelin-env.sh:# export ZEPPELIN_MEM            		# Zeppelin jvm mem options Default -Xms1024m -Xmx1024m -XX:MaxPermSize=512m
      .//bigtop-packages/src/common/zeppelin/zeppelin-env.sh:# export ZEPPELIN_INTP_MEM       		# zeppelin interpreter process jvm mem options. Default -Xms1024m -Xmx1024m -XX:MaxPermSize=512m
      .//build/hadoop/rpm/BUILD/hadoop-2.8.0-src/hadoop-project/pom.xml:    <maven-surefire-plugin.argLine>-Xmx2048m -XX:MaxPermSize=768m -XX:+HeapDumpOnOutOfMemoryError</maven-surefire-plugin.argLine>
      .//CHANGES.txt:    * [BIGTOP-2240] - add -XX:PermSize=1024m -XX:MaxPermSize=1024m to build environment
      .//src/site/xdoc/release-notes.xml:  <li>[<a href='https://issues.apache.org/jira/browse/BIGTOP-2240'>BIGTOP-2240</a>] - add -XX:PermSize=1024m -XX:MaxPermSize=1024m to build environment</li>
      
      1. 55e8bd2faf39bb30a868e9edbe78cfd30062a69f.patch
        9 kB
        Arnaud Launay
      2. BIGTOP-2778.patch
        346 kB
        Arnaud Launay

        Issue Links

          Activity

          Hide
          warwithin YoungWoo Kim added a comment -

          Honestly I'm not sure it is the thing to fix or remove If we remove the vm option, would it be a problem for users who use JDK7 at this moment?

          Show
          warwithin YoungWoo Kim added a comment - Honestly I'm not sure it is the thing to fix or remove If we remove the vm option, would it be a problem for users who use JDK7 at this moment?
          Hide
          asl Arnaud Launay added a comment -

          I think I forgot to create this jira like a month ago )

          Here's the patch:

          https://github.com/alaunay/bigtop/commit/55e8bd2faf39bb30a868e9edbe78cfd30062a69f

          For JDK7, it's no longer supported by bigtop and the minimum has been updated to JDK8, hence, no problem...

          Show
          asl Arnaud Launay added a comment - I think I forgot to create this jira like a month ago ) Here's the patch: https://github.com/alaunay/bigtop/commit/55e8bd2faf39bb30a868e9edbe78cfd30062a69f For JDK7, it's no longer supported by bigtop and the minimum has been updated to JDK8, hence, no problem...
          Hide
          warwithin YoungWoo Kim added a comment -

          Great! Arnaud Launay Feel free to assign this to you. Would you mind posting a patch or sending a PR? Thanks.

          Show
          warwithin YoungWoo Kim added a comment - Great! Arnaud Launay Feel free to assign this to you. Would you mind posting a patch or sending a PR? Thanks.
          Hide
          asl Arnaud Launay added a comment -

          Patch enclosed

          Show
          asl Arnaud Launay added a comment - Patch enclosed
          Hide
          warwithin YoungWoo Kim added a comment -

          Arnaud Launay I've assigned this to you and changed the subject. Please re-generate the patch according to Bigtop's instructions. See "How to generate patches" @ https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute

          Show
          warwithin YoungWoo Kim added a comment - Arnaud Launay I've assigned this to you and changed the subject. Please re-generate the patch according to Bigtop's instructions. See "How to generate patches" @ https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
          Hide
          asl Arnaud Launay added a comment -

          Enclosed !

          Show
          asl Arnaud Launay added a comment - Enclosed !
          Hide
          evans_ye Evans Ye added a comment -

          I find the PR has logs of unrelated code change, things like chram, docs, etc. Can you rebase on the current bigtop master and left the other code changes handled by other JIRAs?

          Show
          evans_ye Evans Ye added a comment - I find the PR has logs of unrelated code change, things like chram, docs, etc. Can you rebase on the current bigtop master and left the other code changes handled by other JIRAs?
          Hide
          asl Arnaud Launay added a comment -

          Agreed, something went wrong. I'll do a clean branch on github, please disregard this one.

          Show
          asl Arnaud Launay added a comment - Agreed, something went wrong. I'll do a clean branch on github, please disregard this one.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user alaunay opened a pull request:

          https://github.com/apache/bigtop/pull/221

          BIGTOP-2778: Delete PermSize / MaxPermsize options, no longer supported by Java 8

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/alaunay/bigtop BIGTOP-2778

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/221.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #221


          commit bdc7989bab787187692080a0da62da7833ed8110
          Author: Arnaud Launay <asl-github@launay.org>
          Date: 2017-05-27T19:30:53Z

          BIGTOP-2778: Delete PermSize / MaxPermsize options, no longer support by Java 8


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user alaunay opened a pull request: https://github.com/apache/bigtop/pull/221 BIGTOP-2778 : Delete PermSize / MaxPermsize options, no longer supported by Java 8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/alaunay/bigtop BIGTOP-2778 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/221.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #221 commit bdc7989bab787187692080a0da62da7833ed8110 Author: Arnaud Launay <asl-github@launay.org> Date: 2017-05-27T19:30:53Z BIGTOP-2778 : Delete PermSize / MaxPermsize options, no longer support by Java 8
          Hide
          evans_ye Evans Ye added a comment -

          The latest patch looks great.
          +1 to merge.
          Let CI tell us how it goes.

          Show
          evans_ye Evans Ye added a comment - The latest patch looks great. +1 to merge. Let CI tell us how it goes.
          Hide
          evans_ye Evans Ye added a comment -

          Committed to master.
          Thanks for the patch, Arnaud Launay.

          Show
          evans_ye Evans Ye added a comment - Committed to master. Thanks for the patch, Arnaud Launay .
          Hide
          asl Arnaud Launay added a comment -

          Out of curiosity, where is the CI ? I can't find a link here on this page (which is a bit sad)

          Show
          asl Arnaud Launay added a comment - Out of curiosity, where is the CI ? I can't find a link here on this page (which is a bit sad)
          Hide
          evans_ye Evans Ye added a comment -

          https://ci.bigtop.apache.org/view/Packages/job/Bigtop-trunk-packages/

          It's scheduled daily. The change hasn't kicked in yet.

          Show
          evans_ye Evans Ye added a comment - https://ci.bigtop.apache.org/view/Packages/job/Bigtop-trunk-packages/ It's scheduled daily. The change hasn't kicked in yet.

            People

            • Assignee:
              asl Arnaud Launay
              Reporter:
              warwithin YoungWoo Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development