Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.1, 1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Support for building bigtop/puppet, bigtop/slaves for debian stretch (next stable).

      It features puppet-4.8, btw.

        Activity

        Hide
        oflebbe Olaf Flebbe added a comment -

        Thanks Evans Ye for actually looking into the code! Thanks for the review!

        Show
        oflebbe Olaf Flebbe added a comment - Thanks Evans Ye for actually looking into the code! Thanks for the review!
        Hide
        evans_ye Evans Ye added a comment -

        Oh silly me. thanks for pointing out.
        +1 to the patch. Thanks Olaf!

        Show
        evans_ye Evans Ye added a comment - Oh silly me. thanks for pointing out. +1 to the patch. Thanks Olaf!
        Hide
        oflebbe Olaf Flebbe added a comment -

        Evans Ye We have a .dockerignore file in place.

        Show
        oflebbe Olaf Flebbe added a comment - Evans Ye We have a .dockerignore file in place.
        Hide
        evans_ye Evans Ye added a comment -
        22	COPY . /tmp/bigtop
        23	RUN cd /tmp/bigtop && ./gradlew && cd && rm -rf /tmp/bigtop
        

        Here we would like to boostrap gradle caches using ./gradlew.
        I see a problem that if a user already have something built in the bigtop repo(output), then entire repo with gigs of artifacts will be
        copied and committed in the image.
        AFAIK, there's no way to eliminate committed layer unless we manually squash the image.

        Perhaps we can clone bigtop repo from github. That way it stays clean. Any better idea?

        Show
        evans_ye Evans Ye added a comment - 22 COPY . /tmp/bigtop 23 RUN cd /tmp/bigtop && ./gradlew && cd && rm -rf /tmp/bigtop Here we would like to boostrap gradle caches using ./gradlew. I see a problem that if a user already have something built in the bigtop repo(output), then entire repo with gigs of artifacts will be copied and committed in the image. AFAIK, there's no way to eliminate committed layer unless we manually squash the image. Perhaps we can clone bigtop repo from github. That way it stays clean. Any better idea?

          People

          • Assignee:
            oflebbe Olaf Flebbe
            Reporter:
            oflebbe Olaf Flebbe
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development