Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2716

Solr build failed when OpenJDK8u_121 is used

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.1
    • Component/s: build
    • Labels:
      None
    • Environment:

      Ubuntu 16.04

      Description

      Ubuntu 16.04 updated openjdk version since Oracle release 8u_121 in Jan 22. This release added more strict check which disabled all JavaScript in documentation.
      http://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html

      This will cause solr failed to build as it has JS in lucene.
      Upstream has patch for this issue.
      https://issues.apache.org/jira/browse/LUCENE-7651
      This fix should be rebased to current solr component.

      1. BIGTOP-2716.patch
        57 kB
        Jun He
      2. BIGTOP-2716.1.patch
        58 kB
        Jun He

        Activity

        Hide
        evans_ye Evans Ye added a comment -

        Committed in branch-1.2.
        Thanks for your patch, Jun He.
        And yes, you should have 2 JIRAs address smoke test and deployment, respectively.

        Show
        evans_ye Evans Ye added a comment - Committed in branch-1.2. Thanks for your patch, Jun He . And yes, you should have 2 JIRAs address smoke test and deployment, respectively.
        Hide
        jun.he Jun He added a comment -

        Sure. Thank you, Evans Ye.
        I'm working on BIGOP-2869, smoke test and deploy.
        I think I should provide seperate patches regard to smoke and deploy, right?

        Show
        jun.he Jun He added a comment - Sure. Thank you, Evans Ye . I'm working on BIGOP-2869, smoke test and deploy. I think I should provide seperate patches regard to smoke and deploy, right?
        Hide
        evans_ye Evans Ye added a comment - - edited

        I'm going to commit this to 1.2 branch to fix Solr build problem. I've verified the patch and it works well. OTOH we can approach solr 6.6.0(BIGTOP-2869) in the master branch.

        Show
        evans_ye Evans Ye added a comment - - edited I'm going to commit this to 1.2 branch to fix Solr build problem. I've verified the patch and it works well. OTOH we can approach solr 6.6.0( BIGTOP-2869 ) in the master branch.
        Hide
        jun.he Jun He added a comment -

        Verified BIGTOP-2716.1.patch with HEAD(6f7e97e93393d)@master, both JDK-8u121 and JD-8u131.
        This patch still works, and created pkg/deb/rpm as expected.

        Show
        jun.he Jun He added a comment - Verified BIGTOP-2716 .1.patch with HEAD(6f7e97e93393d)@master, both JDK-8u121 and JD-8u131. This patch still works, and created pkg/deb/rpm as expected.
        Hide
        jun.he Jun He added a comment - - edited

        Evans Ye, sure I would like to contribute more to bigtop community. And start from solr component would be great for me.
        Pls let me know for anything I should follow up. Thanks.

        Show
        jun.he Jun He added a comment - - edited Evans Ye , sure I would like to contribute more to bigtop community. And start from solr component would be great for me. Pls let me know for anything I should follow up. Thanks.
        Hide
        evans_ye Evans Ye added a comment -

        Jun He the plan is if there's no maintainer willing to maintain the component, then we might drop it. The reason to remove it is not a likely on technical perspective but rather because of the code quality as well as community interest.
        If someone is willing to contribute and become a maintainer, the community is happy to carry on with it and take care of the CI infra and release stuffs.

        Show
        evans_ye Evans Ye added a comment - Jun He the plan is if there's no maintainer willing to maintain the component, then we might drop it. The reason to remove it is not a likely on technical perspective but rather because of the code quality as well as community interest. If someone is willing to contribute and become a maintainer, the community is happy to carry on with it and take care of the CI infra and release stuffs.
        Hide
        jun.he Jun He added a comment -

        Hi, Evans Ye, I'm not working on solr recently. So the plan is to drop it in future v1.3?

        Show
        jun.he Jun He added a comment - Hi, Evans Ye , I'm not working on solr recently. So the plan is to drop it in future v1.3?
        Hide
        evans_ye Evans Ye added a comment -

        Jun He are you still on this?
        We're have another JIRA to remove solr in BIGTOP-2804 since our version is quite old.

        Show
        evans_ye Evans Ye added a comment - Jun He are you still on this? We're have another JIRA to remove solr in BIGTOP-2804 since our version is quite old.
        Hide
        evans_ye Evans Ye added a comment -

        Looks good for me. But I'm not quite familiar with build process though.
        Would be great is experts can chime in.

        Show
        evans_ye Evans Ye added a comment - Looks good for me. But I'm not quite familiar with build process though. Would be great is experts can chime in.
        Hide
        jun.he Jun He added a comment -

        Updated patch for RPM distribution build. Verified locally with OpenJDK-8u111 and 8u121.
        Olaf Flebbe, Roman Shaposhnik, pls help to check. Thanks.

        Show
        jun.he Jun He added a comment - Updated patch for RPM distribution build. Verified locally with OpenJDK-8u111 and 8u121. Olaf Flebbe , Roman Shaposhnik , pls help to check. Thanks.
        Hide
        rvs Roman Shaposhnik added a comment -

        Pushing this to 1.3.0 since we seem to have agreed on how to handle these packages for 1.2.0

        Show
        rvs Roman Shaposhnik added a comment - Pushing this to 1.3.0 since we seem to have agreed on how to handle these packages for 1.2.0
        Hide
        oflebbe Olaf Flebbe added a comment -

        Thanks for your contribution!

        Same comment as BIGTOP-2717: Please make patch work for rpm as well, if possible

        Patch seems to work well.

        Show
        oflebbe Olaf Flebbe added a comment - Thanks for your contribution! Same comment as BIGTOP-2717 : Please make patch work for rpm as well, if possible Patch seems to work well.
        Hide
        jun.he Jun He added a comment - - edited

        Patch to merge upstream fix. Please check if it is OK.

        Show
        jun.he Jun He added a comment - - edited Patch to merge upstream fix. Please check if it is OK.

          People

          • Assignee:
            jun.he Jun He
            Reporter:
            jun.he Jun He
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development