Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0
    • Component/s: tests
    • Labels:
      None

      Description

      ODPi has developed a number of tests for extra validation of Hadoop stacks. All of these tests were developed with, essentially, Bigtop as a reference implementation in mind. It seems reasonable to include those as an option into our battery of smoke tests.

      All of these tests seem to be easy to maintain and they test for reasonable assertions.

        Activity

        Hide
        cos Konstantin Boudnik added a comment -

        Thank you very much for the effort!

        A few comments from the initial glance at it:

        • these are just some runtime tests. Shall they really be in odpi-runtime folder? Is this a vendor-specific suite?
        • Perhaps JarInfo related code could be moved to iTest, if I haven't misread it. Although, this refactoring might be done in a consequent ticket
        • ALc2 headers have html tags <p> and alike
        • In quite a few files, Java code formatting is not Hadoop/Bigtop like. Heck, it isn't even Sun Java Style Guide like, Pease consider reformatting. Also, I see some lines of like 217 characters long or something.
        • JdbcConnector has a bunch of 'odpi' prefixes hardcoded
        • package names are 'odpi'. Should be fixed

        There are a number of the spec tests, which aren't really the integration tests like the ones for Hive and HCat. Can we at least split this patch in two, so there's a way to give it a better review?

        Show
        cos Konstantin Boudnik added a comment - Thank you very much for the effort! A few comments from the initial glance at it: these are just some runtime tests. Shall they really be in odpi-runtime folder? Is this a vendor-specific suite? Perhaps JarInfo related code could be moved to iTest, if I haven't misread it. Although, this refactoring might be done in a consequent ticket ALc2 headers have html tags <p> and alike In quite a few files, Java code formatting is not Hadoop/Bigtop like. Heck, it isn't even Sun Java Style Guide like, Pease consider reformatting. Also, I see some lines of like 217 characters long or something. JdbcConnector has a bunch of 'odpi' prefixes hardcoded package names are 'odpi'. Should be fixed There are a number of the spec tests, which aren't really the integration tests like the ones for Hive and HCat. Can we at least split this patch in two, so there's a way to give it a better review?
        Hide
        rvs Roman Shaposhnik added a comment -

        Konstantin Boudnik thanks for the review! A few quick answers:

        these are just some runtime tests. Shall they really be in odpi-runtime folder? Is this a vendor-specific suite?

        I think initially it would be best to keep them separate from the component-specific smokes (like Hadoop, Hive, etc.) We can eventually decide to merge them with those, but for now I'd rather keep an option of enabling/disabling all of them at once during test runs. I don't think it is a vendor specific, but rather "use case" specific. IOW, it may be desirable for our downstream consumers to run this as a separate test suite.

        ALc2 headers have html tags <p> and alike
        JdbcConnector has a bunch of 'odpi' prefixes hardcoded
        package names are 'odpi'. Should be fixed

        Good catch! Will fix those tomorrow.

        As for the reformatting – I'll try to do my best. Do you think that InteliJ can help here?

        Show
        rvs Roman Shaposhnik added a comment - Konstantin Boudnik thanks for the review! A few quick answers: these are just some runtime tests. Shall they really be in odpi-runtime folder? Is this a vendor-specific suite? I think initially it would be best to keep them separate from the component-specific smokes (like Hadoop, Hive, etc.) We can eventually decide to merge them with those, but for now I'd rather keep an option of enabling/disabling all of them at once during test runs. I don't think it is a vendor specific, but rather "use case" specific. IOW, it may be desirable for our downstream consumers to run this as a separate test suite. ALc2 headers have html tags <p> and alike JdbcConnector has a bunch of 'odpi' prefixes hardcoded package names are 'odpi'. Should be fixed Good catch! Will fix those tomorrow. As for the reformatting – I'll try to do my best. Do you think that InteliJ can help here?
        Hide
        cos Konstantin Boudnik added a comment -

        I see the point on keeping the tests separate. I guess I am ok with that.

        And yes: IntelliJ is absolutely the way to go. You should be able to reformat everything in literally one click (if you formatting profile is configured already Thanks!

        Show
        cos Konstantin Boudnik added a comment - I see the point on keeping the tests separate. I guess I am ok with that. And yes: IntelliJ is absolutely the way to go. You should be able to reformat everything in literally one click (if you formatting profile is configured already Thanks!
        Hide
        rvs Roman Shaposhnik added a comment -

        Konstantin Boudnik please take a look at the new patch

        Show
        rvs Roman Shaposhnik added a comment - Konstantin Boudnik please take a look at the new patch

          People

          • Assignee:
            rvs Roman Shaposhnik
            Reporter:
            rvs Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development