Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: build
    • Labels:
      None

      Description

      This is a backport of https://jira.odpi.org/browse/ODPI-72

      1. BIGTOP-2696.patch.txt
        1 kB
        Roman Shaposhnik

        Activity

        Hide
        rvs Roman Shaposhnik added a comment -

        Evans Ye please take a look at BIGTOP-2702

        Show
        rvs Roman Shaposhnik added a comment - Evans Ye please take a look at BIGTOP-2702
        Hide
        rvs Roman Shaposhnik added a comment -

        Good catch! Sorry for the noise – I'll try to work through this soon, but yeah – I may need your help in the end since you have the most experience with the provisioners.

        Show
        rvs Roman Shaposhnik added a comment - Good catch! Sorry for the noise – I'll try to work through this soon, but yeah – I may need your help in the end since you have the most experience with the provisioners.
        Hide
        evans_ye Evans Ye added a comment -
        Show
        evans_ye Evans Ye added a comment - I see there're some ODPi commits was accidentally committed within this code change. It would be better to have it stripped into one BIGTOP commit. https://github.com/apache/bigtop/commit/40fd25e52cace1245dd669307326c3cb20044335 https://github.com/apache/bigtop/commit/ba4c1bf7e29ba639137259308d8b6e0252ef7fb9 https://github.com/apache/bigtop/commit/d78693bed54fbb239aacff939a2e03663050d887
        Hide
        evans_ye Evans Ye added a comment -

        Hi Roman Shaposhnik,
        Sorry for the late review.
        This no longer works because we've moved the Vagrant Provisioner under bigtop/provisioner directory.
        Please see BIGTOP-2646.

        Since this one is committed already. I suggest to create another JIRA to move this dangleing script over there with proper documentation added.
        I can help with it if you don't have time.

        Show
        evans_ye Evans Ye added a comment - Hi Roman Shaposhnik , Sorry for the late review. This no longer works because we've moved the Vagrant Provisioner under bigtop/provisioner directory. Please see BIGTOP-2646 . Since this one is committed already. I suggest to create another JIRA to move this dangleing script over there with proper documentation added. I can help with it if you don't have time.

          People

          • Assignee:
            rvs Roman Shaposhnik
            Reporter:
            rvs Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development