Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: provisioner
    • Labels:
      None

      Description

      After Docker and Vagrant Provisioner moved to top level provisioner directory, the old code under bigtop-deploy/vm need to be removed.
      For OpenStack Provisioner, since no one is touching it for a while, jay vyas, Minying Lu, Ata Turk can you confirm that it's still working functionally?

        Issue Links

          Activity

          Hide
          evans_ye Evans Ye added a comment -

          Hi all, I personally is not quite sure whether OpenStack is working or not.
          Hence I think here we got two solutions:

          • Move the code to provisioner with the path updated based on an assumption that it should work.
          • Remove OpenStack support in Provisioner

          jay vyas, Minying Lu, Ata Turk, can you have some input here?

          Show
          evans_ye Evans Ye added a comment - Hi all, I personally is not quite sure whether OpenStack is working or not. Hence I think here we got two solutions: Move the code to provisioner with the path updated based on an assumption that it should work. Remove OpenStack support in Provisioner jay vyas , Minying Lu , Ata Turk , can you have some input here?
          Hide
          oflebbe Olaf Flebbe added a comment -

          Hi Evans Ye,

          I agree to remove the openstack code, if we do not get input in a reasonable timeframe (few days). I remember you asked for input regarding this change on the mailing list before, so this should be the last call.

          Show
          oflebbe Olaf Flebbe added a comment - Hi Evans Ye , I agree to remove the openstack code, if we do not get input in a reasonable timeframe (few days). I remember you asked for input regarding this change on the mailing list before, so this should be the last call.
          Hide
          evans_ye Evans Ye added a comment -

          I'll provide a patch to cleanup the stuffs.

          Show
          evans_ye Evans Ye added a comment - I'll provide a patch to cleanup the stuffs.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user evans-ye opened a pull request:

          https://github.com/apache/bigtop/pull/174

          BIGTOP-2647. Clean up code under bigtop-deploy/vm after everything moved to provisioner directory

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/evans-ye/bigtop BIGTOP-2647

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/174.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #174


          commit 294740aaff3c559e4ed8106cde418724448914cd
          Author: Evans Ye <evansye@apache.org>
          Date: 2017-01-21T05:55:57Z

          BIGTOP-2647. Clean up code under bigtop-deploy/vm after everything moved to provisioner directory


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user evans-ye opened a pull request: https://github.com/apache/bigtop/pull/174 BIGTOP-2647 . Clean up code under bigtop-deploy/vm after everything moved to provisioner directory You can merge this pull request into a Git repository by running: $ git pull https://github.com/evans-ye/bigtop BIGTOP-2647 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/174.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #174 commit 294740aaff3c559e4ed8106cde418724448914cd Author: Evans Ye <evansye@apache.org> Date: 2017-01-21T05:55:57Z BIGTOP-2647 . Clean up code under bigtop-deploy/vm after everything moved to provisioner directory
          Hide
          evans_ye Evans Ye added a comment -

          Should be a trivial patch.

          Show
          evans_ye Evans Ye added a comment - Should be a trivial patch.
          Hide
          oflebbe Olaf Flebbe added a comment -

          LGTM

          Show
          oflebbe Olaf Flebbe added a comment - LGTM
          Hide
          evans_ye Evans Ye added a comment -

          Thanks.
          I'v committed this to the trunk.

          Show
          evans_ye Evans Ye added a comment - Thanks. I'v committed this to the trunk.

            People

            • Assignee:
              evans_ye Evans Ye
              Reporter:
              evans_ye Evans Ye
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development