Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: debian, rpm
    • Labels:
      None

      Description

      In bigtop-packages/src/common/hbase/install_hbase.sh :

      export HBASE_CLASSPATH=\$HADOOP_CONF:\$HADOOP_HOME/*:\$HADOOP_HOME/lib/*:\$ZOOKEEPER_HOME/*:\$ZOOKEEPER_HOME/lib/*:\$HBASE_CLASSPATH
      

      \$ZOOKEEPER_HOME/lib/* seems to be redundant since the zookeeper jar is in \$HBASE_HOME/lib

      One symptom is that running 'hbase shell' command results in the following messages:

      SLF4J: Class path contains multiple SLF4J bindings.
      SLF4J: Found binding in jar:file:<path>/hadoop/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class
      SLF4J: Found binding in jar:file:<path>/zookeeper/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tedyu opened a pull request:

          https://github.com/apache/bigtop/pull/128

          BIGTOP-2488 Redundant zookeeper/lib directory

          The PR removes the redundant $ZOOKEEPER_HOME/lib/* from HBASE_CLASSPATH

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tedyu/bigtop master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/128.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #128


          commit 5cbfccc3f3c889e49567abcc568bba7108926cef
          Author: tedyu <yuzhihong@gmail.com>
          Date: 2016-06-23T16:01:13Z

          BIGTOP-2488 Redundant zookeeper/lib directory


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tedyu opened a pull request: https://github.com/apache/bigtop/pull/128 BIGTOP-2488 Redundant zookeeper/lib directory The PR removes the redundant $ZOOKEEPER_HOME/lib/* from HBASE_CLASSPATH You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/bigtop master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #128 commit 5cbfccc3f3c889e49567abcc568bba7108926cef Author: tedyu <yuzhihong@gmail.com> Date: 2016-06-23T16:01:13Z BIGTOP-2488 Redundant zookeeper/lib directory
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/bigtop/pull/128

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/bigtop/pull/128
          Hide
          rvs Roman Shaposhnik added a comment -

          Thanks for the patch Ted! Committed!

          Show
          rvs Roman Shaposhnik added a comment - Thanks for the patch Ted! Committed!
          Hide
          cos Konstantin Boudnik added a comment -

          Please use "git am -s" so it is visible who has signed of on the commit.

          Show
          cos Konstantin Boudnik added a comment - Please use "git am -s" so it is visible who has signed of on the commit.
          Hide
          cos Konstantin Boudnik added a comment -

          And setting up "Affects version" and "Component" is the responsibility of the committer pushing the patch in. Thanks!

          Show
          cos Konstantin Boudnik added a comment - And setting up "Affects version" and "Component" is the responsibility of the committer pushing the patch in. Thanks!
          Hide
          rvs Roman Shaposhnik added a comment -

          Konstantin Boudnik good point on "Affects version" and "Component" ! As for the git am -s I don't actually find it valuable at all. Using git log --pretty=full is a much more reliable way to see who actually pushed what.

          Show
          rvs Roman Shaposhnik added a comment - Konstantin Boudnik good point on "Affects version" and "Component" ! As for the git am -s I don't actually find it valuable at all. Using git log --pretty=full is a much more reliable way to see who actually pushed what.

            People

            • Assignee:
              tedyu Ted Yu
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development