Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2443

inject unzip method to ZipInputStream, accepting regex for include

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 1.2.0
    • Component/s: tests
    • Labels:
      None

      Description

      I must admit, I did a lousy job, when the unzip() method was initially injected into ZipInputStream inside of the JarContent class. Includes are matched to the jar entries using String.contains(), which is a way too explicit.

      Let's add another one, that will accept regex and, even, a list of regex'es.

      1. BIGTOP-2443.2.patch
        7 kB
        Kengo Seki
      2. BIGTOP-2443.1.patch
        3 kB
        Kengo Seki

        Activity

        Hide
        cos Konstantin Boudnik added a comment - - edited

        Pushed to the master, thanks Kengo Seki!

        Show
        cos Konstantin Boudnik added a comment - - edited Pushed to the master, thanks Kengo Seki !
        Hide
        cos Konstantin Boudnik added a comment -

        +1 - the patch looks good, and I am committing this right away!

        Show
        cos Konstantin Boudnik added a comment - +1 - the patch looks good, and I am committing this right away!
        Hide
        cos Konstantin Boudnik added a comment -

        I am terribly sorry. Will do the review tonight.

        Show
        cos Konstantin Boudnik added a comment - I am terribly sorry. Will do the review tonight.
        Hide
        cos Konstantin Boudnik added a comment -

        Thanks for picking this up!
        The review will follow shortly

        Show
        cos Konstantin Boudnik added a comment - Thanks for picking this up! The review will follow shortly
        Hide
        sekikn Kengo Seki added a comment -

        Added unit tests.

        Show
        sekikn Kengo Seki added a comment - Added unit tests.
        Hide
        sekikn Kengo Seki added a comment -

        I mistakenly uploaded a wrong patch. Uploading the right one.

        Show
        sekikn Kengo Seki added a comment - I mistakenly uploaded a wrong patch. Uploading the right one.
        Hide
        sekikn Kengo Seki added a comment -

        Attaching a patch. Tested all injected methods manually.

        Show
        sekikn Kengo Seki added a comment - Attaching a patch. Tested all injected methods manually.

          People

          • Assignee:
            sekikn Kengo Seki
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development