Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2407

Making "force_username_lowercase" variable templatize in puppet module of hue

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: hue
    • Labels:
      None

      Description

      LDAP section in hue.ini has option "force_username_lowercase" which is not templatize. If we can make it templatize then we can easily externalize this variable.

        Issue Links

          Activity

          Hide
          oflebbe Olaf Flebbe added a comment -

          Please do not reuse resolved pull requests. It will spam the jira.

          Thanks.

          Show
          oflebbe Olaf Flebbe added a comment - Please do not reuse resolved pull requests. It will spam the jira. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user amitkabraiiit reopened a pull request:

          https://github.com/apache/bigtop/pull/102

          BIGTOP-2407,BIGTOP-2408,BIGTOP-2409,BIGTOP-2410 : Templatizing hue template variables

          BIGTOP-2407 : Making "force_username_lowercase" variable templatize in puppet module of hue
          BIGTOP-2408 : group_filter variable value is not templatize in puppet module of hue
          BIGTOP-2409 : nt_domain configuration option for hue to connect to Active Directory
          BIGTOP-2410 : Making "ldap_username_pattern" variable templatize in puppet module of hue

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/amitkabraiiit/bigtop master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/102.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #102


          commit 8f9c7bf77a9393b015e16cca91513d30bc5a33d8
          Author: Amit Kabra <akabra@a1kabra-wsl.internal.salesforce.com>
          Date: 2016-04-25T08:58:20Z

          BIGTOP-2407 : Making "force_username_lowercase" variable templatize in puppet module of hue

          commit 2b14bbc2b31dab01726b29b799c163211a3e145e
          Author: Amit Kabra <akabra@a1kabra-wsl.internal.salesforce.com>
          Date: 2016-04-25T09:04:36Z

          BIGTOP-2408 : group_filter variable value is not templatize in puppet module of hue

          commit 4b8d5f25ca960b3d171ea9b2b507c55c09cf8af4
          Author: Amit Kabra <akabra@a1kabra-wsl.internal.salesforce.com>
          Date: 2016-04-25T09:44:35Z

          BIGTOP-2409 : nt_domain configuration option for hue to connect to Active Directory

          commit 19634427f17094ae43e8c6c8621abac079f41b8f
          Author: Amit Kabra <amitkabraiiit@gmail.com>
          Date: 2016-04-26T06:17:08Z

          BIGTOP-2410 : Making ldap_username_pattern variable templatize in puppet module of hue

          commit 1f0c1ec93518da1aac33ad24e9f2603189eb8a0e
          Author: Amit Kabra <amitkabraiiit@gmail.com>
          Date: 2016-05-19T09:42:11Z

          BIGTOP-2438: remote_deployement_dir variable value is not templatize in puppet module of hue for oozie


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user amitkabraiiit reopened a pull request: https://github.com/apache/bigtop/pull/102 BIGTOP-2407 , BIGTOP-2408 , BIGTOP-2409 , BIGTOP-2410 : Templatizing hue template variables BIGTOP-2407 : Making "force_username_lowercase" variable templatize in puppet module of hue BIGTOP-2408 : group_filter variable value is not templatize in puppet module of hue BIGTOP-2409 : nt_domain configuration option for hue to connect to Active Directory BIGTOP-2410 : Making "ldap_username_pattern" variable templatize in puppet module of hue You can merge this pull request into a Git repository by running: $ git pull https://github.com/amitkabraiiit/bigtop master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/102.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #102 commit 8f9c7bf77a9393b015e16cca91513d30bc5a33d8 Author: Amit Kabra <akabra@a1kabra-wsl.internal.salesforce.com> Date: 2016-04-25T08:58:20Z BIGTOP-2407 : Making "force_username_lowercase" variable templatize in puppet module of hue commit 2b14bbc2b31dab01726b29b799c163211a3e145e Author: Amit Kabra <akabra@a1kabra-wsl.internal.salesforce.com> Date: 2016-04-25T09:04:36Z BIGTOP-2408 : group_filter variable value is not templatize in puppet module of hue commit 4b8d5f25ca960b3d171ea9b2b507c55c09cf8af4 Author: Amit Kabra <akabra@a1kabra-wsl.internal.salesforce.com> Date: 2016-04-25T09:44:35Z BIGTOP-2409 : nt_domain configuration option for hue to connect to Active Directory commit 19634427f17094ae43e8c6c8621abac079f41b8f Author: Amit Kabra <amitkabraiiit@gmail.com> Date: 2016-04-26T06:17:08Z BIGTOP-2410 : Making ldap_username_pattern variable templatize in puppet module of hue commit 1f0c1ec93518da1aac33ad24e9f2603189eb8a0e Author: Amit Kabra <amitkabraiiit@gmail.com> Date: 2016-05-19T09:42:11Z BIGTOP-2438 : remote_deployement_dir variable value is not templatize in puppet module of hue for oozie
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user amitkabraiiit closed the pull request at:

          https://github.com/apache/bigtop/pull/102

          Show
          githubbot ASF GitHub Bot added a comment - Github user amitkabraiiit closed the pull request at: https://github.com/apache/bigtop/pull/102
          Hide
          oflebbe Olaf Flebbe added a comment -

          Will commit it in a minute

          Show
          oflebbe Olaf Flebbe added a comment - Will commit it in a minute
          Hide
          oflebbe Olaf Flebbe added a comment -

          LGTM, +1

          Show
          oflebbe Olaf Flebbe added a comment - LGTM, +1
          Hide
          amitkabraiiit Amit Kabra added a comment -

          I also added a pull request as you suggested last time : https://github.com/apache/bigtop/pull/102

          Show
          amitkabraiiit Amit Kabra added a comment - I also added a pull request as you suggested last time : https://github.com/apache/bigtop/pull/102
          Hide
          amitkabraiiit Amit Kabra added a comment -

          Olaf Flebbe : Can you please review it and submit it ? Thank you.

          Show
          amitkabraiiit Amit Kabra added a comment - Olaf Flebbe : Can you please review it and submit it ? Thank you.

            People

            • Assignee:
              amitkabraiiit Amit Kabra
              Reporter:
              amitkabraiiit Amit Kabra
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development