Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: tests
    • Labels:
      None

      Description

      Adding smoke tests for Tajo component

      1. BIGTOP-2180.2.patch
        7 kB
        Yeongeon KIM
      2. BIGTOP-2180.patch
        9 kB
        Yeongeon KIM

        Activity

        Hide
        yeongeon Yeongeon KIM added a comment -

        I have checked three readme files under the bigtop-tests folder and had some concerns which one should be made at first among three sub-projects ; smoke-tests, test-artifacts and test-execution.
        There are mentions in the last two readme files that the old ways using by XML would be merged with the smoke-tests of new way.
        So, Could I make the smoke-tests only this time? Otherwise, should I deal with others together?

        Show
        yeongeon Yeongeon KIM added a comment - I have checked three readme files under the bigtop-tests folder and had some concerns which one should be made at first among three sub-projects ; smoke-tests, test-artifacts and test-execution. There are mentions in the last two readme files that the old ways using by XML would be merged with the smoke-tests of new way. So, Could I make the smoke-tests only this time? Otherwise, should I deal with others together?
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user yeongeon opened a pull request:

        https://github.com/apache/bigtop/pull/67

        BIGTOP-2180: Add smoke-test scripts using gradle for Apache Tajo. (This commit depends on BIGTOP-2179)

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/yeongeon/bigtop BIGTOP-2180

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/bigtop/pull/67.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #67


        commit aeb4581587de5516110dfa10ef20261b6c723615
        Author: yeongeon <yeongeon@gmail.com>
        Date: 2015-12-16T10:50:58Z

        BIGTOP-2179: Add packaging scripts for Apache Tajo

        commit 17eb9ac0d4e3f2a328bb9b1d13d7650802786afa
        Author: yeongeon <yeongeon@gmail.com>
        Date: 2015-12-17T02:31:22Z

        BIGTOP-2180: Add smoke-test scripts for Apache Tajo. (This commit depends on BIGTOP-2179)


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user yeongeon opened a pull request: https://github.com/apache/bigtop/pull/67 BIGTOP-2180 : Add smoke-test scripts using gradle for Apache Tajo. (This commit depends on BIGTOP-2179 ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/yeongeon/bigtop BIGTOP-2180 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit aeb4581587de5516110dfa10ef20261b6c723615 Author: yeongeon <yeongeon@gmail.com> Date: 2015-12-16T10:50:58Z BIGTOP-2179 : Add packaging scripts for Apache Tajo commit 17eb9ac0d4e3f2a328bb9b1d13d7650802786afa Author: yeongeon <yeongeon@gmail.com> Date: 2015-12-17T02:31:22Z BIGTOP-2180 : Add smoke-test scripts for Apache Tajo. (This commit depends on BIGTOP-2179 )
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jayunit100 commented on the pull request:

        https://github.com/apache/bigtop/pull/67#issuecomment-165332657

        Looks like this has come along nicely. I can't review it myself because I don't have the time, but I think it's close to being mergeable now. Puppet recipes are optional I guess although we prefer to have submitted with the packaging a lot of the time. Thanks a lot for doing this .!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jayunit100 commented on the pull request: https://github.com/apache/bigtop/pull/67#issuecomment-165332657 Looks like this has come along nicely. I can't review it myself because I don't have the time, but I think it's close to being mergeable now. Puppet recipes are optional I guess although we prefer to have submitted with the packaging a lot of the time. Thanks a lot for doing this .!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user yeongeon commented on the pull request:

        https://github.com/apache/bigtop/pull/67#issuecomment-165361391

        Thanks for your mention. Please let me know if there are any other problems at this commits.
        The deployment using the puppet also was included in my plan so, it would be to see next time.

        Show
        githubbot ASF GitHub Bot added a comment - Github user yeongeon commented on the pull request: https://github.com/apache/bigtop/pull/67#issuecomment-165361391 Thanks for your mention. Please let me know if there are any other problems at this commits. The deployment using the puppet also was included in my plan so, it would be to see next time.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jayunit100 commented on the pull request:

        https://github.com/apache/bigtop/pull/67#issuecomment-166343355

        Thanks again.

        • i think this looks good for a first pass provided its tested.
        • @c0s or @oflebbe or anyone else want to review ? To be honest, id be +1 to merging it if others are ok.
        • I dont actively work on bigtop right now so Im hesitant to give it a +1 with no other review.
        Show
        githubbot ASF GitHub Bot added a comment - Github user jayunit100 commented on the pull request: https://github.com/apache/bigtop/pull/67#issuecomment-166343355 Thanks again. i think this looks good for a first pass provided its tested. @c0s or @oflebbe or anyone else want to review ? To be honest, id be +1 to merging it if others are ok. I dont actively work on bigtop right now so Im hesitant to give it a +1 with no other review.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/67#issuecomment-166594132

        Oops... I left minor comments on PR/66.

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/67#issuecomment-166594132 Oops... I left minor comments on PR/66.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user yeongeon commented on the pull request:

        https://github.com/apache/bigtop/pull/67#issuecomment-167192076

        Thanks guys. I have pushed two fixed.

        Show
        githubbot ASF GitHub Bot added a comment - Github user yeongeon commented on the pull request: https://github.com/apache/bigtop/pull/67#issuecomment-167192076 Thanks guys. I have pushed two fixed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user yeongeon closed the pull request at:

        https://github.com/apache/bigtop/pull/67

        Show
        githubbot ASF GitHub Bot added a comment - Github user yeongeon closed the pull request at: https://github.com/apache/bigtop/pull/67
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user yeongeon opened a pull request:

        https://github.com/apache/bigtop/pull/76

        BIGTOP-2180: Add smoke-test scripts using gradle for Apache Tajo.

        It's a new PR that is separated from BIGTOP-2179.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/yeongeon/bigtop BIGTOP-2180

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/bigtop/pull/76.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #76


        commit ebf82a2ff52d38e4cd0589a4f25e25fb1d11800b
        Author: yeongeon <yeongeon@gmail.com>
        Date: 2015-12-17T02:31:22Z

        BIGTOP-2180: Add smoke-test scripts using gradle for Apache Tajo.

        commit 5e5bfc266c2ff05ec206a1ba10c55d786e3d1d5f
        Author: yeongeon <yeongeon@gmail.com>
        Date: 2015-12-22T09:19:57Z

        BIGTOP-2180: Add smoke-test scripts using gradle for Apache Tajo.

        commit 99c7df685c460508574962228a8a5bc62d760c4b
        Author: yeongeon <yeongeon@gmail.com>
        Date: 2015-12-17T02:31:22Z

        BIGTOP-2180: Add smoke-test scripts using gradle for Apache Tajo.

        commit 36e790121e32eb4ad751c4d692fb0fd61f9e3e2b
        Author: yeongeon <yeongeon@gmail.com>
        Date: 2016-01-27T07:27:11Z

        Merge branch 'BIGTOP-2180' of https://github.com/yeongeon/bigtop into BIGTOP-2180


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user yeongeon opened a pull request: https://github.com/apache/bigtop/pull/76 BIGTOP-2180 : Add smoke-test scripts using gradle for Apache Tajo. It's a new PR that is separated from BIGTOP-2179 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/yeongeon/bigtop BIGTOP-2180 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/76.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #76 commit ebf82a2ff52d38e4cd0589a4f25e25fb1d11800b Author: yeongeon <yeongeon@gmail.com> Date: 2015-12-17T02:31:22Z BIGTOP-2180 : Add smoke-test scripts using gradle for Apache Tajo. commit 5e5bfc266c2ff05ec206a1ba10c55d786e3d1d5f Author: yeongeon <yeongeon@gmail.com> Date: 2015-12-22T09:19:57Z BIGTOP-2180 : Add smoke-test scripts using gradle for Apache Tajo. commit 99c7df685c460508574962228a8a5bc62d760c4b Author: yeongeon <yeongeon@gmail.com> Date: 2015-12-17T02:31:22Z BIGTOP-2180 : Add smoke-test scripts using gradle for Apache Tajo. commit 36e790121e32eb4ad751c4d692fb0fd61f9e3e2b Author: yeongeon <yeongeon@gmail.com> Date: 2016-01-27T07:27:11Z Merge branch ' BIGTOP-2180 ' of https://github.com/yeongeon/bigtop into BIGTOP-2180
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user c0s commented on the pull request:

        https://github.com/apache/bigtop/pull/76#issuecomment-176977739

        This seems to be fine. Will commit this to the master in a bit. Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user c0s commented on the pull request: https://github.com/apache/bigtop/pull/76#issuecomment-176977739 This seems to be fine. Will commit this to the master in a bit. Thanks!
        Hide
        cos Konstantin Boudnik added a comment -

        Pushed to the master. Thanks Yeongoon

        Show
        cos Konstantin Boudnik added a comment - Pushed to the master. Thanks Yeongoon

          People

          • Assignee:
            yeongeon Yeongeon KIM
            Reporter:
            yeongeon Yeongeon KIM
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development