Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2172

get rid of gradlew inside of subprojects

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: tests
    • Labels:
      None

      Description

      It seems that having a separate gradlew under bigtop-tests/smoke-tests goes against KISS principle. With it we'll have to separately support two different wrappers. Instead, we can just use the top level gradlew file, when the tests have to be executed.

      This works just fine (from the top-level)

      ./gradlew -b bigtop-tests/smoke-tests/build.gradle clean test -Dsmoke.tests=mapreduce
      

        Issue Links

          Activity

          Hide
          evans_ye Evans Ye added a comment -

          Although I'm a bit late. +1 for the patch.

          Show
          evans_ye Evans Ye added a comment - Although I'm a bit late. +1 for the patch.
          Hide
          cos Konstantin Boudnik added a comment -

          Pushed to the master.

          Show
          cos Konstantin Boudnik added a comment - Pushed to the master.
          Hide
          cos Konstantin Boudnik added a comment -

          Here's the patch

          Show
          cos Konstantin Boudnik added a comment - Here's the patch
          Hide
          cos Konstantin Boudnik added a comment -

          I will post the patch later in the day. Thanks!

          Show
          cos Konstantin Boudnik added a comment - I will post the patch later in the day. Thanks!
          Hide
          evans_ye Evans Ye added a comment -

          I like the merge. We should make all the things available in top level gradle tasks.

          Show
          evans_ye Evans Ye added a comment - I like the merge. We should make all the things available in top level gradle tasks.
          Hide
          cos Konstantin Boudnik added a comment -

          Perhaps needs to be forked into a separate JIRA, but we also need to get rid of explicit reference to compileGroovy task elsewhere smoke-tests. This task will be executed automatically and there's no need to require a user to run it.

          Show
          cos Konstantin Boudnik added a comment - Perhaps needs to be forked into a separate JIRA, but we also need to get rid of explicit reference to compileGroovy task elsewhere smoke-tests. This task will be executed automatically and there's no need to require a user to run it.

            People

            • Assignee:
              cos Konstantin Boudnik
              Reporter:
              cos Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development