Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2150

Reversing directional build behavior

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: build
    • Labels:
      None

      Description

      BOM directional graph implementation was introduced in BIGTOP-2025 By default it tries to satisfy all the dependencies by building the foundation components first, then their dependents, and so on.

      However, it seems like an undesirable behavior in most cases. Let's reverse it so by default no dependencies are build (as in the original behavior). In order to trigger the directional build
      -Dbuildwithdeps=true should be explicitly set.

      The change won't affect anything we're currently doing with CI or else.

      1. BIGTOP-2150.patch
        2 kB
        Konstantin Boudnik

        Activity

        Hide
        cos Konstantin Boudnik added a comment -

        Here's the fix. Please check my logic

        Show
        cos Konstantin Boudnik added a comment - Here's the fix. Please check my logic
        Hide
        sergey.soldatov Sergey Soldatov added a comment -

        Looks good and works as described

        Show
        sergey.soldatov Sergey Soldatov added a comment - Looks good and works as described
        Hide
        evans_ye Evans Ye added a comment -

        LGTM +1

        Show
        evans_ye Evans Ye added a comment - LGTM +1
        Hide
        cos Konstantin Boudnik added a comment -

        Thanks guys, will commit this shortly.

        Show
        cos Konstantin Boudnik added a comment - Thanks guys, will commit this shortly.
        Hide
        cos Konstantin Boudnik added a comment -

        Pushed to the master, thanks for the reviews!

        Show
        cos Konstantin Boudnik added a comment - Pushed to the master, thanks for the reviews!

          People

          • Assignee:
            cos Konstantin Boudnik
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development