Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2147

Minor nits in bigpetstore-spark/README.md

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: blueprints
    • Labels:

      Description

      1. It says that the Spark application currently builds against Spark 1.1.0, but in build.gradle, sparkVersion is specified as 1.3.0.

      2. Some underscores in code blocks are escaped by backslashes, but it's unnecessary.

      113 ```
      114 spark-submit --master local[2] --class org.apache.bigtop.bigpetstore.spark.etl.SparkETL bigpetstore-spark-X.jar generated\_data transformed\_data
      115 ```
      
      123 ```
      124 spark-submit --master local[2] --class org.apache.bigtop.bigpetstore.spark.analytics.PetStoreStatistics bigpetstore-spark-X.jar transformed\_data PetStoreStats.json
      125 ```
      
      171 ```
      172 spark-submit --master local[2] --class org.apache.bigtop.bigpetstore.spark.analytics.RecommendProducts bigpetstore-spark-X.jar transformed\_data recommendations.json
      173 ```
      

      3. PetStoreStatistics is described as:

      134 This will output a JSON file to the /tmp directory, which has formatting (approximately) like this.
      

      but the exemplar command outputs a JSON file to the current directory.

        Activity

        Hide
        rnowling RJ Nowling added a comment - - edited

        Thanks, Kengo Seki ! I'll take a look a bit later and commit.

        Show
        rnowling RJ Nowling added a comment - - edited Thanks, Kengo Seki ! I'll take a look a bit later and commit.
        Hide
        evans_ye Evans Ye added a comment -

        Simple doc improvement looks good as well. +1.

        Show
        evans_ye Evans Ye added a comment - Simple doc improvement looks good as well. +1.
        Hide
        evans_ye Evans Ye added a comment -

        Committed. Thanks Kengo Seki

        Show
        evans_ye Evans Ye added a comment - Committed. Thanks Kengo Seki
        Hide
        rnowling RJ Nowling added a comment -

        Thank you, Kengo Seki! And thanks Evans Ye for the review and commit!

        Show
        rnowling RJ Nowling added a comment - Thank you, Kengo Seki ! And thanks Evans Ye for the review and commit!

          People

          • Assignee:
            sekikn Kengo Seki
            Reporter:
            sekikn Kengo Seki
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development