Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2085

gradle toolchain should install necessary puppet modules

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: toolchain
    • Labels:
      None

      Description

      Its clumsy to run gradle toolchain-puppetmodules toolchain and you get weird errors if you forget to install puppet modules

        Activity

        Hide
        oflebbe Olaf Flebbe added a comment -

        The argument of Konstantin Boudnik is valid. Why fix it in gradle ? We need the puppet modules when installing the toolchain and when we deploy.
        So why not installing it along with puppet?

        I open up a different one.

        Show
        oflebbe Olaf Flebbe added a comment - The argument of Konstantin Boudnik is valid. Why fix it in gradle ? We need the puppet modules when installing the toolchain and when we deploy. So why not installing it along with puppet? I open up a different one.
        Hide
        evans_ye Evans Ye added a comment -

        Hmm. I was actually thinking that what you proposed it's a good way to go. So why don't we do it that way?

        Show
        evans_ye Evans Ye added a comment - Hmm. I was actually thinking that what you proposed it's a good way to go. So why don't we do it that way?
        Hide
        oflebbe Olaf Flebbe added a comment -

        No don't do it this way ...

        Show
        oflebbe Olaf Flebbe added a comment - No don't do it this way ...
        Hide
        oflebbe Olaf Flebbe added a comment - - edited

        Hi Konstantin Boudnik and Evans Ye: thanks for your comments!

        We cannot fix this dependency with puppet, since a puppet module cannot install a puppet module. It will not be picked up by the current run.

        How about including all the needed puppet modules with the puppet installer ?

        i.e. puppet module install stdlib }} and {{puppet module install apt into puppetize.sh ?

        Then the bigtop/puppet docker image will include everything needed for running toolchain or ci, respectivly. And bare metal is handled, too.

        Show
        oflebbe Olaf Flebbe added a comment - - edited Hi Konstantin Boudnik and Evans Ye : thanks for your comments! We cannot fix this dependency with puppet, since a puppet module cannot install a puppet module. It will not be picked up by the current run. How about including all the needed puppet modules with the puppet installer ? i.e. puppet module install stdlib }} and {{puppet module install apt into puppetize.sh ? Then the bigtop/puppet docker image will include everything needed for running toolchain or ci, respectivly. And bare metal is handled, too.
        Hide
        cos Konstantin Boudnik added a comment -

        Fixing the dependencies at the toolchain level looks like a more elegant idea. However, this patch addresses the immediate gap and can be committed, and then we can address the dep improvement separately. Just IMO, of course.

        Show
        cos Konstantin Boudnik added a comment - Fixing the dependencies at the toolchain level looks like a more elegant idea. However, this patch addresses the immediate gap and can be committed, and then we can address the dep improvement separately. Just IMO, of course.
        Hide
        evans_ye Evans Ye added a comment -

        I've some different idea and would like to discuss - If someone is running toolchain in the environment that does not have java, it still works by issuing puppet apply command and toolchain will install java for the environment. In that case we still need puppet module being installed first. But the patch implement the dependency at gradle side only.
        Maybe we can include puppet-modules.pp in installer.pp and add dependency in jdk.pp?

        Show
        evans_ye Evans Ye added a comment - I've some different idea and would like to discuss - If someone is running toolchain in the environment that does not have java, it still works by issuing puppet apply command and toolchain will install java for the environment. In that case we still need puppet module being installed first. But the patch implement the dependency at gradle side only. Maybe we can include puppet-modules.pp in installer.pp and add dependency in jdk.pp?
        Hide
        evans_ye Evans Ye added a comment -

        I guess what Olaf Flebbe is trying to say is:
        because of the Java 8 support, we introduce the additional requirement of apt module in toolchain. As a result toolchain should now include puppet module installation on the fly.

        Show
        evans_ye Evans Ye added a comment - I guess what Olaf Flebbe is trying to say is: because of the Java 8 support, we introduce the additional requirement of apt module in toolchain. As a result toolchain should now include puppet module installation on the fly.
        Hide
        oflebbe Olaf Flebbe added a comment -

        See patch

        Show
        oflebbe Olaf Flebbe added a comment - See patch
        Hide
        oflebbe Olaf Flebbe added a comment -

        I just wanted the depency automatically executed.

        Show
        oflebbe Olaf Flebbe added a comment - I just wanted the depency automatically executed.
        Hide
        cos Konstantin Boudnik added a comment -

        If I understand this correctly, it might be already done: check the toolchain-puppetmodules task of the build.

        Show
        cos Konstantin Boudnik added a comment - If I understand this correctly, it might be already done: check the toolchain-puppetmodules task of the build.

          People

          • Assignee:
            oflebbe Olaf Flebbe
            Reporter:
            oflebbe Olaf Flebbe
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development