[BIGTOP-2057] null check doesn't safeguard against non-existing values in the BOM config

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.1.0
• Component/s: build
• Assignee: Konstantin I Boudnik
• Reporter: Konstantin I Boudnik
• Created: 19/Sep/15 18:38
• Updated: 19/Sep/15 22:03
• Resolved: 19/Sep/15 19:18

Description

BIGTOP-2051 has switched the build to use configuration properties instead of java properties. One of the unfortunate side effects of such dynamism is that null checks don't work as expected anymore, as empty elements of the config would be assigned with a ConfigObject instance even after simply null check. That leads to failures for component builds where some elements are omitted all-together, e.g bigtop-utils.

Instead of null checks I propose to user .isEmpty()

Issue Links

• is broken by: BIGTOP-2051 Get rid of hair-brain environment vars left after make-based build