Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2057

null check doesn't safeguard against non-existing values in the BOM config

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: build
    • Labels:
      None

      Description

      BIGTOP-2051 has switched the build to use configuration properties instead of java properties. One of the unfortunate side effects of such dynamism is that null checks don't work as expected anymore, as empty elements of the config would be assigned with a ConfigObject instance even after simply null check. That leads to failures for component builds where some elements are omitted all-together, e.g bigtop-utils.

      Instead of null checks I propose to user .isEmpty()

      1. BIGTOP-2057.patch
        2 kB
        Konstantin Boudnik
      2. BIGTOP-2057.patch
        2 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          cos Konstantin Boudnik added a comment - - edited

          To immediately address CI failures. Validating is easy - just run
          gradle bigtop-utils-clean

          Show
          cos Konstantin Boudnik added a comment - - edited To immediately address CI failures. Validating is easy - just run gradle bigtop-utils-clean
          Hide
          cos Konstantin Boudnik added a comment -

          While we are at it - adding a small improvement to the -info ugliness.

          Show
          cos Konstantin Boudnik added a comment - While we are at it - adding a small improvement to the -info ugliness.
          Hide
          evans_ye Evans Ye added a comment -

          Yup. The patch uploaded 10 mins ago looks good to me.
          +1.

          Show
          evans_ye Evans Ye added a comment - Yup. The patch uploaded 10 mins ago looks good to me. +1.
          Hide
          cos Konstantin Boudnik added a comment -

          Pushed to the master - thanks a lot for reviewing it so fast man!

          Show
          cos Konstantin Boudnik added a comment - Pushed to the master - thanks a lot for reviewing it so fast man!
          Hide
          rvs Roman Shaposhnik added a comment -

          +1. LGTM.

          Show
          rvs Roman Shaposhnik added a comment - +1. LGTM.

            People

            • Assignee:
              cos Konstantin Boudnik
              Reporter:
              cos Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development