Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2017

Rebase bigtop-slaves on bigtop-puppet

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:
      None

      Description

      Rebase the docker images on top of each other: See comments in BIGTOP-2015

      1. BIGTOP-2017.1.patch
        7 kB
        Olaf Flebbe
      2. BIGTOP-2017.2.patch
        6 kB
        Olaf Flebbe
      3. BIGTOP-2017.3.patch
        6 kB
        Olaf Flebbe

        Issue Links

          Activity

          Hide
          oflebbe Olaf Flebbe added a comment -

          Patch, still testing

          Show
          oflebbe Olaf Flebbe added a comment - Patch, still testing
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          Evans Ye: Thats the rebase of the bigtop-slaves... Tested.

          Show
          oflebbe Olaf Flebbe added a comment - - edited Evans Ye : Thats the rebase of the bigtop-slaves... Tested.
          Hide
          evans_ye Evans Ye added a comment -

          LGTM, though this sort of blocked by the discussing thread in BIGTOP-1908. I'll get back to review this once we reach consensus.

          Show
          evans_ye Evans Ye added a comment - LGTM, though this sort of blocked by the discussing thread in BIGTOP-1908 . I'll get back to review this once we reach consensus.
          Hide
          oflebbe Olaf Flebbe added a comment -

          OMG I had a couple of typos in it. ...

          Show
          oflebbe Olaf Flebbe added a comment - OMG I had a couple of typos in it. ...
          Hide
          evans_ye Evans Ye added a comment -

          Is this ready for review?

          Show
          evans_ye Evans Ye added a comment - Is this ready for review?
          Hide
          oflebbe Olaf Flebbe added a comment -

          yes

          Show
          oflebbe Olaf Flebbe added a comment - yes
          Hide
          evans_ye Evans Ye added a comment -

          Looks nice and neat.
          +1

          Show
          evans_ye Evans Ye added a comment - Looks nice and neat. +1
          Hide
          oflebbe Olaf Flebbe added a comment -

          thanks for the nice review! committed.

          Show
          oflebbe Olaf Flebbe added a comment - thanks for the nice review! committed.
          Hide
          oflebbe Olaf Flebbe added a comment -

          thanks for the nice review! committed.

          Show
          oflebbe Olaf Flebbe added a comment - thanks for the nice review! committed.

            People

            • Assignee:
              oflebbe Olaf Flebbe
              Reporter:
              oflebbe Olaf Flebbe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development