Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: general
    • Labels:
      None
    1. BIGTOP-2009.patch
      238 kB
      Venkata Srinivasa Rao Kolla
    2. BIGTOP-2009.patch
      238 kB
      Venkata Srinivasa Rao Kolla

      Activity

      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Added new test for chgrp, cp, ls, mv, du, put, get, mkdir, stat and touchz

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Added new test for chgrp, cp, ls, mv, du, put, get, mkdir, stat and touchz
      Hide
      warwithin YoungWoo Kim added a comment -

      Venkata Srinivasa Rao Kolla , I got a test failure:

      Results :
      
      Failed tests:   TestCpFileProtocolWithDirectory(org.apache.bigtop.itest.hadoop.hdfs.TestCp): Copied files do not match
      
      Tests run: 8, Failures: 1, Errors: 0, Skipped: 0
      
      +  @Test
      +  public void TestCpFileProtocolWithDirectory() {
      +    println("TestCpFileProtocolWithDirectory");
      +    //copy a dir from local to hdfs
      +    sh.exec("hdfs dfs -cp file:///$USERDIR/$testCpInputs $TESTDIR/test_temp_1");
      +    assertTrue("copy command failed on HDFS", sh.getRet() == 0);
      +    sh.exec("hdfs dfs -ls -R $TESTDIR/test_temp_1");
      +    assertTrue("listing files/directories failed on HDFS", sh.getRet() == 0);
      +    List out_msgs_fp = sh.getOut();
      +    Boolean success_fp_1= false;
      +    Boolean success_fp_2= false;
      +    Iterator out_iter_fp = out_msgs_fp.iterator();
      +    while (out_iter_fp.hasNext()) {
      +      String next_val = out_iter_fp.next();
      +      if (next_val.contains("-rw-r--r--") && next_val.contains("$USERNAME") &&
      +          next_val.contains("$TESTDIR/test_temp_1/test_2.txt")) {
      +        success_fp_1 = true;
      +      }
      +      if (next_val.contains("-rw-r--r--") && next_val.contains("$USERNAME") &&
      +          next_val.contains("$TESTDIR/test_temp_1/mapred_tutorial.pdf"))  {
      +        success_fp_2 = true;
      +      }
      +    }
      +    assertTrue("Copied files do not match",
      +               success_fp_1 == true && success_fp_2 == true);
      +  }
      

      Looks like that the file 'mapred_tutorial.pdf' is missing. The rest of the patch and tests looks good to me.
      Please revise the patch then I'll commit it. Thanks!

      Show
      warwithin YoungWoo Kim added a comment - Venkata Srinivasa Rao Kolla , I got a test failure: Results : Failed tests: TestCpFileProtocolWithDirectory(org.apache.bigtop.itest.hadoop.hdfs.TestCp): Copied files do not match Tests run: 8, Failures: 1, Errors: 0, Skipped: 0 + @Test + public void TestCpFileProtocolWithDirectory() { + println("TestCpFileProtocolWithDirectory"); + //copy a dir from local to hdfs + sh.exec("hdfs dfs -cp file:///$USERDIR/$testCpInputs $TESTDIR/test_temp_1"); + assertTrue("copy command failed on HDFS", sh.getRet() == 0); + sh.exec("hdfs dfs -ls -R $TESTDIR/test_temp_1"); + assertTrue("listing files/directories failed on HDFS", sh.getRet() == 0); + List out_msgs_fp = sh.getOut(); + Boolean success_fp_1= false; + Boolean success_fp_2= false; + Iterator out_iter_fp = out_msgs_fp.iterator(); + while (out_iter_fp.hasNext()) { + String next_val = out_iter_fp.next(); + if (next_val.contains("-rw-r--r--") && next_val.contains("$USERNAME") && + next_val.contains("$TESTDIR/test_temp_1/test_2.txt")) { + success_fp_1 = true; + } + if (next_val.contains("-rw-r--r--") && next_val.contains("$USERNAME") && + next_val.contains("$TESTDIR/test_temp_1/mapred_tutorial.pdf")) { + success_fp_2 = true; + } + } + assertTrue("Copied files do not match", + success_fp_1 == true && success_fp_2 == true); + } Looks like that the file 'mapred_tutorial.pdf' is missing. The rest of the patch and tests looks good to me. Please revise the patch then I'll commit it. Thanks!
      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Yeah sure.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Yeah sure.
      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      I overlooked it in my final verification. Now corrected it. Thanks a lot for pointing it out. Please check the attached latest patch.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - I overlooked it in my final verification. Now corrected it. Thanks a lot for pointing it out. Please check the attached latest patch.
      Hide
      warwithin YoungWoo Kim added a comment -

      Committed!

      Venkata Srinivasa Rao Kolla , Thank you for your contribution!

      Show
      warwithin YoungWoo Kim added a comment - Committed! Venkata Srinivasa Rao Kolla , Thank you for your contribution!
      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Thank you YoungWoo.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Thank you YoungWoo.
      Hide
      cos Konstantin Boudnik added a comment - - edited

      The patch doesn't comply with formatting guidelines, and uses printlns instead of proper logging, BTW.

      Show
      cos Konstantin Boudnik added a comment - - edited The patch doesn't comply with formatting guidelines, and uses printlns instead of proper logging, BTW.
      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Konstantin Boudnik Please help to share if there is some documentation with formatting guidelines.
      Does the below relevant to formatting guidelines?
      https://poi.apache.org/guidelines.html#CodeStyle.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Konstantin Boudnik Please help to share if there is some documentation with formatting guidelines. Does the below relevant to formatting guidelines? https://poi.apache.org/guidelines.html#CodeStyle .
      Hide
      cos Konstantin Boudnik added a comment -

      the code requirements are listed (I hope all of them in our How to Contribute page. Specifically:
      Follow Apache Hadoop formatting guidelines:
      No trailing whitespace on lines
      Code must be formatted according to Sun's conventions, with one exception:
      Indent two spaces per level, not four.

      Hope this helps. Thanks!

      Show
      cos Konstantin Boudnik added a comment - the code requirements are listed (I hope all of them in our How to Contribute page. Specifically: Follow Apache Hadoop formatting guidelines: No trailing whitespace on lines Code must be formatted according to Sun's conventions, with one exception: Indent two spaces per level, not four. Hope this helps. Thanks!
      Hide
      cos Konstantin Boudnik added a comment -

      Oh, BTW - these new tests: is there any overlap with TestCLI and TestDFSCLI by any chance? Cause we are running a very comprehensive set of the CLI test on the cluster with these two.

      Show
      cos Konstantin Boudnik added a comment - Oh, BTW - these new tests: is there any overlap with TestCLI and TestDFSCLI by any chance? Cause we are running a very comprehensive set of the CLI test on the cluster with these two.
      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Konstantin Boudnik I will check and let you know on this.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Konstantin Boudnik I will check and let you know on this.
      Hide
      cos Konstantin Boudnik added a comment -

      Any progress on this? Thanks

      Show
      cos Konstantin Boudnik added a comment - Any progress on this? Thanks

        People

        • Assignee:
          kollavenkat Venkata Srinivasa Rao Kolla
          Reporter:
          kollavenkat Venkata Srinivasa Rao Kolla
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development