Bigtop
  1. Bigtop
  2. BIGTOP-2

License headers need to be added

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: general
    • Labels:
      None

      Description

      License/copyright headers are not present in the source - they need to be added.

      1. license_header_src_pkg_common.diff
        65 kB
        Andrew Bayer
      2. license_headers.diff
        265 kB
        Andrew Bayer

        Activity

        Andrew Bayer created issue -
        Hide
        Andrew Bayer added a comment -

        First chunk of license header additions/replacements/etc. I'll have the test stuff ready next - I need some pointers/help on what files in the debian packaging source should/shouldn't be getting headers added for formatting reasons, etc.

        Show
        Andrew Bayer added a comment - First chunk of license header additions/replacements/etc. I'll have the test stuff ready next - I need some pointers/help on what files in the debian packaging source should/shouldn't be getting headers added for formatting reasons, etc.
        Andrew Bayer made changes -
        Field Original Value New Value
        Attachment license_header_src_pkg_common.diff [ 12488660 ]
        Hide
        Andrew Bayer added a comment -

        Here's pretty much everything with headers added. Exceptions are test data, various packaging files that don't seem to have an obvious comment format, and the Debian copyright files, ironically enough. I'm honestly not sure what the right content or format should be there, so I'm deferring to those with more packaging wizardry than myself. =)

        Show
        Andrew Bayer added a comment - Here's pretty much everything with headers added. Exceptions are test data, various packaging files that don't seem to have an obvious comment format, and the Debian copyright files, ironically enough. I'm honestly not sure what the right content or format should be there, so I'm deferring to those with more packaging wizardry than myself. =)
        Andrew Bayer made changes -
        Attachment license_headers.diff [ 12488914 ]
        Hide
        Bruno Mahé added a comment -

        The patches look good to me.

        Show
        Bruno Mahé added a comment - The patches look good to me.
        Andrew Bayer made changes -
        Fix Version/s 0.1.0 [ 12317549 ]
        Component/s General [ 12315313 ]
        Hide
        Andrew Bayer added a comment -

        Committed.

        Show
        Andrew Bayer added a comment - Committed.
        Andrew Bayer made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Workflow jira [ 12624252 ] no-reopen-closed, patch-avail [ 12631089 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12631089 ] patch-available, re-open possible [ 12666173 ]
        Roman Shaposhnik made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        21h 4m 1 Andrew Bayer 02/Aug/11 19:27
        Resolved Resolved Closed Closed
        328d 21h 28m 1 Roman Shaposhnik 26/Jun/12 16:56

          People

          • Assignee:
            Andrew Bayer
            Reporter:
            Andrew Bayer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development