Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: general
    • Labels:
      None
    1. BIGTOP-1981.patch
      30 kB
      Venkata Srinivasa Rao Kolla
    2. BIGTOP-1981.patch
      30 kB
      Venkata Srinivasa Rao Kolla
    3. BIGTOP-1981.patch
      32 kB
      Venkata Srinivasa Rao Kolla

      Activity

      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Added tests for hdfs -test, -text and -count functionlaity.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Added tests for hdfs -test, -text and -count functionlaity.
      Hide
      warwithin YoungWoo Kim added a comment -

      Now, BIGTOP-2009 has been resolved. Please rebase the patch to master. It looks like that there are same test_data/* files in this patch.

      Show
      warwithin YoungWoo Kim added a comment - Now, BIGTOP-2009 has been resolved. Please rebase the patch to master. It looks like that there are same test_data/* files in this patch.
      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Sure.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Sure.
      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Rebased with master branch and attached patch again.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Rebased with master branch and attached patch again.
      Hide
      warwithin YoungWoo Kim added a comment -
      +  @Test
      +  public void testCmdTextMultipleFiles() {
      +    println("testCmdTextMultipleFiles");
      +    // invoke text with 2 files
      +    sh.exec("hdfs dfs -text $TESTDIR/$testCmdTextInputs/test_1.txt " +
      +            "$TESTDIR/$testCmdTextInputs/mapred_tutorial.pdf | " +
      
      

      Please update the 'testCmdTextMultipleFiles' test. the rest of tests works fine for me.

      Show
      warwithin YoungWoo Kim added a comment - + @Test + public void testCmdTextMultipleFiles() { + println("testCmdTextMultipleFiles"); + // invoke text with 2 files + sh.exec("hdfs dfs -text $TESTDIR/$testCmdTextInputs/test_1.txt " + + "$TESTDIR/$testCmdTextInputs/mapred_tutorial.pdf | " + Please update the 'testCmdTextMultipleFiles' test. the rest of tests works fine for me.
      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Removed the identified files and replaced with different files and uploaded the patch.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Removed the identified files and replaced with different files and uploaded the patch.
      Hide
      warwithin YoungWoo Kim added a comment -

      +1

      Will commit it shortly. Thanks Venkata Srinivasa Rao Kolla !

      Show
      warwithin YoungWoo Kim added a comment - +1 Will commit it shortly. Thanks Venkata Srinivasa Rao Kolla !
      Hide
      kollavenkat Venkata Srinivasa Rao Kolla added a comment -

      Thank you YoungWoo.

      Show
      kollavenkat Venkata Srinivasa Rao Kolla added a comment - Thank you YoungWoo.
      Hide
      cos Konstantin Boudnik added a comment - - edited

      Venkata Srinivasa Rao Kolla , is there any change you can check that these tests aren't covered by TestCLI already? If so - there's no point of running duplicated tests, especially considering that we share CLI configuration with the upstream Hadoo and the maintenance is next to zero.
      The configuration file for the said test could be found under bigtop-tests/test-artifacts/hadoop/src/main/resources/clitest_data/*.xml
      Thanks

      Show
      cos Konstantin Boudnik added a comment - - edited Venkata Srinivasa Rao Kolla , is there any change you can check that these tests aren't covered by TestCLI already? If so - there's no point of running duplicated tests, especially considering that we share CLI configuration with the upstream Hadoo and the maintenance is next to zero. The configuration file for the said test could be found under bigtop-tests/test-artifacts/hadoop/src/main/resources/clitest_data/*.xml Thanks

        People

        • Assignee:
          kollavenkat Venkata Srinivasa Rao Kolla
          Reporter:
          kollavenkat Venkata Srinivasa Rao Kolla
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development