Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1463 We need a better automation of the release process.
  3. BIGTOP-1947

Fix RAT plugin configuration to be able to RAT-validate all published artifacts

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.0.0, 1.1.0
    • Component/s: build
    • Labels:
      None

      Description

      Right now an attempt to run mvn deploy -Prelease -f bigtop-test-framework/pom.xml will fail the RAT-check because some of the static test data files don't have ASL header. This needs to be properly excluded from the validation.

      1. BIGTOP-1947.patch
        10 kB
        Konstantin Boudnik
      2. BIGTOP-1947.patch
        10 kB
        Konstantin Boudnik
      3. BIGTOP-1947.patch
        7 kB
        Konstantin Boudnik
      4. BIGTOP-1947.patch
        6 kB
        Konstantin Boudnik
      5. BIGTOP-1947.patch
        0.9 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          cos Konstantin Boudnik added a comment -

          Something like this needs to be done for other modules as well: packagesmokes, etc.

          Show
          cos Konstantin Boudnik added a comment - Something like this needs to be done for other modules as well: packagesmokes, etc.
          Hide
          cos Konstantin Boudnik added a comment -

          That seems to take care about the issue

          Show
          cos Konstantin Boudnik added a comment - That seems to take care about the issue
          Hide
          cos Konstantin Boudnik added a comment -

          With properly formatted patch

          Show
          cos Konstantin Boudnik added a comment - With properly formatted patch
          Hide
          cos Konstantin Boudnik added a comment -

          Seems to be the final version of the patch. Appreciate the review.

          Show
          cos Konstantin Boudnik added a comment - Seems to be the final version of the patch. Appreciate the review.
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          This fixes definitely a couple of issues, so this will get a +1 from me.

          But I still get rat unapproved licenses... This is handled in different JIRAS?

          Show
          oflebbe Olaf Flebbe added a comment - - edited This fixes definitely a couple of issues, so this will get a +1 from me. But I still get rat unapproved licenses... This is handled in different JIRAS?
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          I looked into the remaining licenses. The patch can maybe improved by adding a
          <exclude>build/**</exclude>

          The license report at bigtop-test-framework/target/rat.txt listed a lot of generated files in the bigtop-test-framework/build directory. The rat exclude seems to be relative to the bigtop-test-framework

          Will you update the patch, or is something else wrong here at my side?

          Show
          oflebbe Olaf Flebbe added a comment - - edited I looked into the remaining licenses. The patch can maybe improved by adding a <exclude>build/**</exclude> The license report at bigtop-test-framework/target/rat.txt listed a lot of generated files in the bigtop-test-framework/build directory. The rat exclude seems to be relative to the bigtop-test-framework Will you update the patch, or is something else wrong here at my side?
          Hide
          cos Konstantin Boudnik added a comment -

          Yup, there's linked JIRA BIGTOP-1951

          Show
          cos Konstantin Boudnik added a comment - Yup, there's linked JIRA BIGTOP-1951
          Hide
          cos Konstantin Boudnik added a comment -

          That's pretty good addition, Olaf. Fixed patch is uploaded.

          Show
          cos Konstantin Boudnik added a comment - That's pretty good addition, Olaf. Fixed patch is uploaded.
          Hide
          oflebbe Olaf Flebbe added a comment -

          Looks fine to me, +1, will apply to master in a minute

          Show
          oflebbe Olaf Flebbe added a comment - Looks fine to me, +1, will apply to master in a minute
          Hide
          oflebbe Olaf Flebbe added a comment -

          Thanks !

          Show
          oflebbe Olaf Flebbe added a comment - Thanks !
          Hide
          cos Konstantin Boudnik added a comment -

          Thank you!

          Show
          cos Konstantin Boudnik added a comment - Thank you!

            People

            • Assignee:
              cos Konstantin Boudnik
              Reporter:
              cos Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development