Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1932

[BigPetStore] Add larger product collection

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: blueprints
    • Labels:
      None

      Description

      Using the new product generator feature from BIGTOP-1918, we should add a product collection which adds more fields to the existing products, resulting in more products.

        Issue Links

          Activity

          Hide
          rnowling RJ Nowling added a comment -

          This patch:

          • Adds a medium-size product collection with more fields and more products. (It does not add new product types.)
          • Adds an enumeration to Constants for choosing the product collection. Medium is now the default.
          • Cleans up the output format for DiscretePDF
          • Simplifies and improves the weight generation for the multinomial model
          • Adds field exclusions to the multinomial model and adds category, price, and unit price initially. (Eventually, we will want to come up with an approach for weights for numeric ranges.)
          Show
          rnowling RJ Nowling added a comment - This patch: Adds a medium-size product collection with more fields and more products. (It does not add new product types.) Adds an enumeration to Constants for choosing the product collection. Medium is now the default. Cleans up the output format for DiscretePDF Simplifies and improves the weight generation for the multinomial model Adds field exclusions to the multinomial model and adds category, price, and unit price initially. (Eventually, we will want to come up with an approach for weights for numeric ranges.)
          Hide
          rnowling RJ Nowling added a comment -

          jay vyas Review please.

          Show
          rnowling RJ Nowling added a comment - jay vyas Review please.
          Hide
          jayunit100 jay vyas added a comment -

          +1 and tested. however

          • RJ Nowling can you run when you apply this patch and commit --fix-whitespace ? Looks like you added some tabs and so on.

          In a later patch, im going to suggest.

          • Can you add a unit test for DiscretePDF.java toString ? if it seems like it might be something you'll want to rely on.
          • Can we also add a unit test to confirm that we have more fields? Its kinda scary that we can add all these new constants and behavious and all unit tests still pass w/o modification
          Show
          jayunit100 jay vyas added a comment - +1 and tested. however RJ Nowling can you run when you apply this patch and commit --fix-whitespace ? Looks like you added some tabs and so on. In a later patch, im going to suggest. Can you add a unit test for DiscretePDF.java toString ? if it seems like it might be something you'll want to rely on. Can we also add a unit test to confirm that we have more fields? Its kinda scary that we can add all these new constants and behavious and all unit tests still pass w/o modification
          Hide
          rnowling RJ Nowling added a comment -

          jay vyas I'd be happy to add more unit tests before committing. Most of the product fields are dynamics (outside of a few required fields) – I'll need to think of a good way to handle it in tests. Also, the architecture is very composable which is why I can replace large units

          Show
          rnowling RJ Nowling added a comment - jay vyas I'd be happy to add more unit tests before committing. Most of the product fields are dynamics (outside of a few required fields) – I'll need to think of a good way to handle it in tests. Also, the architecture is very composable which is why I can replace large units
          Hide
          rnowling RJ Nowling added a comment -

          jay vyas I added the following on top of the changes already in the patch:

          • Some unit tests, particularly of toString
          • Renamed DiscretePDF to MultinomialPDF
          • Fixed handling of edge cases in BoundedMultiModalGaussian

          I then committed the changes.

          Show
          rnowling RJ Nowling added a comment - jay vyas I added the following on top of the changes already in the patch: Some unit tests, particularly of toString Renamed DiscretePDF to MultinomialPDF Fixed handling of edge cases in BoundedMultiModalGaussian I then committed the changes.

            People

            • Assignee:
              rnowling RJ Nowling
              Reporter:
              rnowling RJ Nowling
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development