Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1894

Snappy development packages are missing from bigtop_toolchain

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: build
    • Labels:
      None

      Description

      bigtop_toolchain does not install snappy development packages.

      1. BIGTOP-1894.1.patch
        3 kB
        Olaf Flebbe
      2. BIGTOP-1894.2.patch
        4 kB
        Olaf Flebbe
      3. BIGTOP-1894.3.patch
        4 kB
        Olaf Flebbe
      4. BIGTOP-1894.4.patch
        4 kB
        Olaf Flebbe

        Activity

        Hide
        oflebbe Olaf Flebbe added a comment -

        Not sure we should fix it in 1.0.0, though

        Show
        oflebbe Olaf Flebbe added a comment - Not sure we should fix it in 1.0.0, though
        Hide
        oflebbe Olaf Flebbe added a comment -

        Jonathan Kelly : Patch could be improved if you can state the name of the package for amazon -linux.

        Show
        oflebbe Olaf Flebbe added a comment - Jonathan Kelly : Patch could be improved if you can state the name of the package for amazon -linux.
        Hide
        jonathak Jonathan Kelly added a comment -

        It's snappy-devel for AmazonLinux as well.

        Show
        jonathak Jonathan Kelly added a comment - It's snappy-devel for AmazonLinux as well.
        Hide
        oflebbe Olaf Flebbe added a comment -

        Added snappy-devel for Amazon-Linux as well

        Show
        oflebbe Olaf Flebbe added a comment - Added snappy-devel for Amazon-Linux as well
        Hide
        evans_ye Evans Ye added a comment -

        I'm up for including snappy by default, but that should be valid across all the supporting OSs instead RHEL and Amazon only. Before doing that, what's your take on this Konstantin Boudnik?

        Show
        evans_ye Evans Ye added a comment - I'm up for including snappy by default, but that should be valid across all the supporting OSs instead RHEL and Amazon only. Before doing that, what's your take on this Konstantin Boudnik ?
        Hide
        oflebbe Olaf Flebbe added a comment -

        snappy should be default for all os. I see no point in not doing it since the overhead is very lean and if someone needs it is there anyhow. It was an oversight from my side that it was not included in the debian toolchain part.

        Show
        oflebbe Olaf Flebbe added a comment - snappy should be default for all os. I see no point in not doing it since the overhead is very lean and if someone needs it is there anyhow. It was an oversight from my side that it was not included in the debian toolchain part.
        Hide
        cos Konstantin Boudnik added a comment -

        Thanks for checking wrt 1.0 release. Please commit it there as well. And then I will cut the RC

        Show
        cos Konstantin Boudnik added a comment - Thanks for checking wrt 1.0 release. Please commit it there as well. And then I will cut the RC
        Hide
        evans_ye Evans Ye added a comment -

        The patch can not apply. It also need to be updated so that snappy is enabled by default on all the supported OSs. Let's move it to 1.1.

        Show
        evans_ye Evans Ye added a comment - The patch can not apply. It also need to be updated so that snappy is enabled by default on all the supported OSs. Let's move it to 1.1.
        Hide
        cos Konstantin Boudnik added a comment -

        As patch isn't applicable anymore, I am canceling the PA status

        Show
        cos Konstantin Boudnik added a comment - As patch isn't applicable anymore, I am canceling the PA status
        Hide
        oflebbe Olaf Flebbe added a comment -

        Updated w/r to master

        Show
        oflebbe Olaf Flebbe added a comment - Updated w/r to master
        Hide
        oflebbe Olaf Flebbe added a comment -

        Evans Ye Please Review

        Show
        oflebbe Olaf Flebbe added a comment - Evans Ye Please Review
        Hide
        evans_ye Evans Ye added a comment -

        Reviewed and tested. The patch is good +1. I'll push later.

        Show
        evans_ye Evans Ye added a comment - Reviewed and tested. The patch is good +1. I'll push later.
        Hide
        evans_ye Evans Ye added a comment -

        Oops! Discovered that the opensuse package list does not include snappy-devel. Please add it in.

        Show
        evans_ye Evans Ye added a comment - Oops! Discovered that the opensuse package list does not include snappy-devel. Please add it in.
        Hide
        oflebbe Olaf Flebbe added a comment - - edited

        Ooops. Fixed. Thanks for discovering this Feel free to commit...

        Show
        oflebbe Olaf Flebbe added a comment - - edited Ooops. Fixed. Thanks for discovering this Feel free to commit...
        Hide
        evans_ye Evans Ye added a comment -

        +1. The new patch works perfectly.
        I've committed and pushed to the master.
        Thanks for the quick response Olaf Flebbe.

        Show
        evans_ye Evans Ye added a comment - +1. The new patch works perfectly. I've committed and pushed to the master. Thanks for the quick response Olaf Flebbe .

          People

          • Assignee:
            oflebbe Olaf Flebbe
            Reporter:
            oflebbe Olaf Flebbe
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development