bigtop_toolchain does not install snappy development packages.
Not sure we should fix it in 1.0.0, though
Jonathan Kelly : Patch could be improved if you can state the name of the package for amazon -linux.
It's snappy-devel for AmazonLinux as well.
Added snappy-devel for Amazon-Linux as well
I'm up for including snappy by default, but that should be valid across all the supporting OSs instead RHEL and Amazon only. Before doing that, what's your take on this Konstantin Boudnik?
snappy should be default for all os. I see no point in not doing it since the overhead is very lean and if someone needs it is there anyhow. It was an oversight from my side that it was not included in the debian toolchain part.
Thanks for checking wrt 1.0 release. Please commit it there as well. And then I will cut the RC
The patch can not apply. It also need to be updated so that snappy is enabled by default on all the supported OSs. Let's move it to 1.1.
As patch isn't applicable anymore, I am canceling the PA status
Updated w/r to master
Evans Ye Please Review
Reviewed and tested. The patch is good +1. I'll push later.
Oops! Discovered that the opensuse package list does not include snappy-devel. Please add it in.
Ooops. Fixed. Thanks for discovering this Feel free to commit...
+1. The new patch works perfectly.
I've committed and pushed to the master.
Thanks for the quick response Olaf Flebbe.