Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1892

Current required version of gradle 2.4 is not used everywhere

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: deployment
    • Labels:
      None

      Description

      Based on the current state of puppet orchestration, Bigtop requires gradle 2.4, but this is not used/stated on all places.

      1. BIGTOP-1892.2.patch
        2 kB
        Martin Bukatovic
      2. BIGTOP-1892.1.patch
        2 kB
        Martin Bukatovic

        Activity

        Hide
        oflebbe Olaf Flebbe added a comment -

        LGTM: +1 as well. WIll apply it in a few minutes to trunk

        Show
        oflebbe Olaf Flebbe added a comment - LGTM: +1 as well. WIll apply it in a few minutes to trunk
        Hide
        mbukatov Martin Bukatovic added a comment -

        Changing the commit message to JIRA synopsis.

        Show
        mbukatov Martin Bukatovic added a comment - Changing the commit message to JIRA synopsis.
        Hide
        warwithin YoungWoo Kim added a comment -

        Looks good! Martin Bukatovic. It would be nice if this JIRA has a same summary with the patch's one. Also Bigtop community encourage contributors to follow some rules to make patches, please see https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute

        Overall it looks good to me. if you revise patch with correct commit message, I believe it would be ready to commit!

        Thanks.

        Show
        warwithin YoungWoo Kim added a comment - Looks good! Martin Bukatovic . It would be nice if this JIRA has a same summary with the patch's one. Also Bigtop community encourage contributors to follow some rules to make patches, please see https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute Overall it looks good to me. if you revise patch with correct commit message, I believe it would be ready to commit! Thanks.
        Hide
        mbukatov Martin Bukatovic added a comment -

        Attaching proposed patch.

        Show
        mbukatov Martin Bukatovic added a comment - Attaching proposed patch.

          People

          • Assignee:
            mbukatov Martin Bukatovic
            Reporter:
            mbukatov Martin Bukatovic
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development