Bigtop
  1. Bigtop
  2. BIGTOP-186

whirr package ships source code and needs some permissions fixes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 0.4.0
    • Component/s: general
    • Labels:
      None

      Description

      This is actually an upstream problem, but this is to track and perhaps offer a fix for upstream.

      1. BIGTOP-186-2.patch
        2 kB
        Peter Linnell
      2. BIGTOP-186.patch
        0.7 kB
        Peter Linnell

        Activity

        Hide
        Peter Linnell added a comment -

        There is also build directories included in:

        hadoop-0.20-debuginfo.amd64.xml
        hue-common.amd64.xml

        Some logs are also packaged:

        ./hue-common.amd64.xml: <file name="/usr/share/hue/desktop/logs/*
        ./hadoop-pig.xml: <file name="/usr/lib/pig/build/pig-0.8.1-cdh3u2/src/docs/build/webapp/WEB-INF/logs/*
        ./hadoop-0.20-source.xml: <file name="/usr/src/hadoop-0.20/docs/build/webapp/WEB-INF/logs/*
        ./hadoop-0.20-source.xml: <file name="/usr/src/hadoop-0.20/docs/cn/build/webapp/WEB-INF/logs/*
        ./whirr.xml: <file name="/usr/lib/whirr/cli/whirr.log" owners="-1" perm="" user="" group=""/>

        Show
        Peter Linnell added a comment - There is also build directories included in: hadoop-0.20-debuginfo.amd64.xml hue-common.amd64.xml Some logs are also packaged: ./hue-common.amd64.xml: <file name="/usr/share/hue/desktop/logs/* ./hadoop-pig.xml: <file name="/usr/lib/pig/build/pig-0.8.1-cdh3u2/src/docs/build/webapp/WEB-INF/logs/* ./hadoop-0.20-source.xml: <file name="/usr/src/hadoop-0.20/docs/build/webapp/WEB-INF/logs/* ./hadoop-0.20-source.xml: <file name="/usr/src/hadoop-0.20/docs/cn/build/webapp/WEB-INF/logs/* ./whirr.xml: <file name="/usr/lib/whirr/cli/whirr.log" owners="-1" perm="" user="" group=""/>
        Hide
        Bruno Mahé added a comment -

        Sorry but your patch doesn't match the current content for whirr.
        Here is a quick package review from latest build in trunk:

        • All the files are 755. Only executable files should be 755
        rwxr-xr-x    1 root    root                      274 Feb 23 14:39 /usr/lib/whirr/BUILD.txt
        -rwxr-xr-x    1 root    root                    24006 Feb 23 14:44 /usr/lib/whirr/CHANGES.txt
        -rwxr-xr-x    1 root    root                    37114 Feb 23 14:39 /usr/lib/whirr/LICENSE.txt
        -rwxr-xr-x    1 root    root                      406 Feb 23 14:39 /usr/lib/whirr/NOTICE.txt
        -rwxr-xr-x    1 root    root                     1854 Feb 23 14:39 /usr/lib/whirr/README.txt
        

        => These files should be 644 and in %

        {docdir}
        /usr/lib/whirr/build-tools

        => Should not exist

        drwxr-xr-x    2 root    root                        0 Feb 23 14:39 /usr/lib/whirr/cli/src
        drwxr-xr-x    2 root    root                        0 Feb 23 14:39 /usr/lib/whirr/core/src
        

        => Should not exist at all. No need to bundle the source

        -rwxr-xr-x    1 root    root                     5775 Feb 23 14:48 /usr/lib/whirr/cli/pom.xml

        => Delete all pom.xml

        /usr/lib/whirr/conf

        => Should be a symlink to /etc/whirr/conf if needed. If not needed we should just have /etc/whirr/conf

        drwxr-xr-x    2 root    root                        0 Apr  9 17:54 /usr/lib/whirr/docs
        lrwxr-xr-x    1 root    root                       30 Apr  9 17:54 /usr/lib/whirr/docs/whirr-0.7.1.13 -> //usr/share/doc/whirr-0.7.1.13
        

        => Seems fishy to me

        /usr/lib/whirr/examples

        => Probably better with the docs

        Show
        Bruno Mahé added a comment - Sorry but your patch doesn't match the current content for whirr. Here is a quick package review from latest build in trunk: All the files are 755. Only executable files should be 755 rwxr-xr-x 1 root root 274 Feb 23 14:39 /usr/lib/whirr/BUILD.txt -rwxr-xr-x 1 root root 24006 Feb 23 14:44 /usr/lib/whirr/CHANGES.txt -rwxr-xr-x 1 root root 37114 Feb 23 14:39 /usr/lib/whirr/LICENSE.txt -rwxr-xr-x 1 root root 406 Feb 23 14:39 /usr/lib/whirr/NOTICE.txt -rwxr-xr-x 1 root root 1854 Feb 23 14:39 /usr/lib/whirr/README.txt => These files should be 644 and in % {docdir} /usr/lib/whirr/build-tools => Should not exist drwxr-xr-x 2 root root 0 Feb 23 14:39 /usr/lib/whirr/cli/src drwxr-xr-x 2 root root 0 Feb 23 14:39 /usr/lib/whirr/core/src => Should not exist at all. No need to bundle the source -rwxr-xr-x 1 root root 5775 Feb 23 14:48 /usr/lib/whirr/cli/pom.xml => Delete all pom.xml /usr/lib/whirr/conf => Should be a symlink to /etc/whirr/conf if needed. If not needed we should just have /etc/whirr/conf drwxr-xr-x 2 root root 0 Apr 9 17:54 /usr/lib/whirr/docs lrwxr-xr-x 1 root root 30 Apr 9 17:54 /usr/lib/whirr/docs/whirr-0.7.1.13 -> //usr/share/doc/whirr-0.7.1.13 => Seems fishy to me /usr/lib/whirr/examples => Probably better with the docs
        Hide
        Peter Linnell added a comment -

        I'll update the patch.

        Show
        Peter Linnell added a comment - I'll update the patch.
        Hide
        Peter Linnell added a comment -

        Updated Patch

        Tested with RPM. Testing Debian now.

        Show
        Peter Linnell added a comment - Updated Patch Tested with RPM. Testing Debian now.
        Hide
        Peter Linnell added a comment -

        Debian looks good..

        Show
        Peter Linnell added a comment - Debian looks good..
        Hide
        Roman Shaposhnik added a comment -

        +1 and committed.

        Show
        Roman Shaposhnik added a comment - +1 and committed.

          People

          • Assignee:
            Peter Linnell
            Reporter:
            Peter Linnell
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development