Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1828

Puppet: Tachyon does not get formatted before tachyon daemons are started up

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: deployment
    • Labels:
      None

      Description

      A non-formatted cluster can have tachyon-master started failed.
      There's also a configuration error which does not have tachyon master defined propertly.

      1. BIGTOP-1828.patch
        2 kB
        Evans Ye
      2. BIGTOP-1828.patch
        2 kB
        Evans Ye

        Activity

        Hide
        evans_ye Evans Ye added a comment -

        Late generation of configuration files can also have a non-configured tachyon-master being started up, which is not able to be connected by tachyon tfs command.

        Show
        evans_ye Evans Ye added a comment - Late generation of configuration files can also have a non-configured tachyon-master being started up, which is not able to be connected by tachyon tfs command.
        Hide
        evans_ye Evans Ye added a comment -

        Patch submitted. Now tachyon can start working right after deployed.

        Show
        evans_ye Evans Ye added a comment - Patch submitted. Now tachyon can start working right after deployed.
        Hide
        cos Konstantin Boudnik added a comment -

        Have no idea about the backside story of it, but patch seems to be reasonable. How the formatting happens though? I don't see any additional commands get executed?

        Show
        cos Konstantin Boudnik added a comment - Have no idea about the backside story of it, but patch seems to be reasonable. How the formatting happens though? I don't see any additional commands get executed?
        Hide
        evans_ye Evans Ye added a comment -

        Hey cos, thanks for looking into this.
        There's a resource already doing the formatting job:

           exec {
                "tachyon formatting":
                   command => "/usr/lib/tachyon/bin/tachyon format",
                   require => [ Package["tachyon"]]
            }
        

        This JIRA is primary addressing ordering issue. That is to format tachyon before tachyon master gets started.
        Otherwise the daemon will fail to start.

        I find it's better to have all the configurations ready before formatting.
        So, upload another patch to fix this.

        Show
        evans_ye Evans Ye added a comment - Hey cos, thanks for looking into this. There's a resource already doing the formatting job: exec { "tachyon formatting" : command => "/usr/lib/tachyon/bin/tachyon format" , require => [ Package[ "tachyon" ]] } This JIRA is primary addressing ordering issue. That is to format tachyon before tachyon master gets started. Otherwise the daemon will fail to start. I find it's better to have all the configurations ready before formatting. So, upload another patch to fix this.
        Hide
        evans_ye Evans Ye added a comment - - edited

        I've tested the new patch with BIGTOP-1824 and BIGTOP-1829, since its the only way to get a working tachyon cluster:
        A simple way to test tachyon setup(from tachyon document):

        /usr/lib/tachyon/bin/tachyon runTests
        
        Show
        evans_ye Evans Ye added a comment - - edited I've tested the new patch with BIGTOP-1824 and BIGTOP-1829 , since its the only way to get a working tachyon cluster: A simple way to test tachyon setup(from tachyon document): /usr/lib/tachyon/bin/tachyon runTests
        Hide
        cos Konstantin Boudnik added a comment -

        Patch looks good +1
        I will commit it by the end of the day, unless you do it before

        Show
        cos Konstantin Boudnik added a comment - Patch looks good +1 I will commit it by the end of the day, unless you do it before
        Hide
        evans_ye Evans Ye added a comment -

        Committed. Thanks cos!

        Show
        evans_ye Evans Ye added a comment - Committed. Thanks cos!

          People

          • Assignee:
            evans_ye Evans Ye
            Reporter:
            evans_ye Evans Ye
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development