Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1810

Spark thriftserver service does not indicate success

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: spark
    • Labels:
      None
    • Environment:

      centos

      Description

      Although the thriftsever starts running the return code is wrong, so systemctl reports a failure to start. Currently checkstatusofproc tests for the pid which is supposed to be stored in "/var/run/spark/$

      {DAEMON}

      .pid", but this file does not exist. I have a patch for this which I have tested to confirm that the service indicates success/failure appropriately.

      1. BIGTOP-1810.1.patch
        2 kB
        Matthew Russell

        Activity

        Hide
        m.russell Matthew Russell added a comment -

        Patch, uses similar method to spark-master service definition

        Show
        m.russell Matthew Russell added a comment - Patch, uses similar method to spark-master service definition
        Hide
        warwithin YoungWoo Kim added a comment - - edited

        Good catch Matthew! I'll commit this shortly.

        Konstantin Boudnik, Please assign this issue to Matthew Russell. Thanks!

        Show
        warwithin YoungWoo Kim added a comment - - edited Good catch Matthew! I'll commit this shortly. Konstantin Boudnik , Please assign this issue to Matthew Russell . Thanks!
        Hide
        evans_ye Evans Ye added a comment - - edited

        It looks like this JIRA needs a little bit push. Konstantin Boudnik would you mind help to add developer?
        YoungWoo Kim do you think this is still valid after spark upgraded to 1.3.1?

        Show
        evans_ye Evans Ye added a comment - - edited It looks like this JIRA needs a little bit push. Konstantin Boudnik would you mind help to add developer? YoungWoo Kim do you think this is still valid after spark upgraded to 1.3.1?
        Hide
        cos Konstantin Boudnik added a comment -

        Evans Ye, I've assigned the ticket to Matthew Russell if that's what you meant

        Show
        cos Konstantin Boudnik added a comment - Evans Ye , I've assigned the ticket to Matthew Russell if that's what you meant
        Hide
        cos Konstantin Boudnik added a comment -

        When the patch is ready to review, please change the JIRA state to "Patch Available" so reviewers can see them.

        Show
        cos Konstantin Boudnik added a comment - When the patch is ready to review, please change the JIRA state to "Patch Available" so reviewers can see them.
        Hide
        cos Konstantin Boudnik added a comment -

        jay vyas, YoungWoo Kim, could you please review this. Trying to get 1.0 branching here. Thanks!

        Show
        cos Konstantin Boudnik added a comment - jay vyas , YoungWoo Kim , could you please review this. Trying to get 1.0 branching here. Thanks!
        Hide
        jayunit100 jay vyas added a comment - - edited

        applies cleanly, +1 from me ! dont have apache creds on me at the moment to commit it

        Show
        jayunit100 jay vyas added a comment - - edited applies cleanly, +1 from me ! dont have apache creds on me at the moment to commit it
        Hide
        cos Konstantin Boudnik added a comment -

        Committed and pushed to the master. Thanks for review, Jay. Thanks for the patch Matthew!

        Show
        cos Konstantin Boudnik added a comment - Committed and pushed to the master. Thanks for review, Jay. Thanks for the patch Matthew!

          People

          • Assignee:
            m.russell Matthew Russell
            Reporter:
            m.russell Matthew Russell
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development