Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1783

Import BigPetStore Data Generator into BigTop

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: blueprints
    • Labels:
      None

      Description

      It's time to move the BigPetStore data generator from GitHub rnowling/bigpetstore-data-generator into BigTop.

        Issue Links

          Activity

          Hide
          jayunit100 jay vyas added a comment -

          yup and tie the whole gradle build for the bigpetstore suite to that, as the primary dependency. part of this task will be restructuring the gradle build

          Show
          jayunit100 jay vyas added a comment - yup and tie the whole gradle build for the bigpetstore suite to that, as the primary dependency. part of this task will be restructuring the gradle build
          Hide
          rnowling RJ Nowling added a comment -

          jay vyas I created a separate issue (BIGTOP-1785) for updating the Gradle build.

          Show
          rnowling RJ Nowling added a comment - jay vyas I created a separate issue ( BIGTOP-1785 ) for updating the Gradle build.
          Hide
          rnowling RJ Nowling added a comment - - edited

          I added a patch containing:

          • Data generator source code
          • Gradle build files
          • Groovy example scripts
          • README.md
          • Data files under src/main/resources from external data sources

          Note that the external data are from:

          As far as I know, all licenses are compatible with the Apache license, but we may consider updating the Gradle build to download the files as part of the build instead of hosting them in BigTop.

          I added Apache License headers to all of the Gradle, Groovy, and Java sources.

          Show
          rnowling RJ Nowling added a comment - - edited I added a patch containing: Data generator source code Gradle build files Groovy example scripts README.md Data files under src/main/resources from external data sources Note that the external data are from: U.S. Census Bureau's American Community Survey Name Database , which itself is based on data from the U.S. Census Bureau The Zip Code Database project As far as I know, all licenses are compatible with the Apache license, but we may consider updating the Gradle build to download the files as part of the build instead of hosting them in BigTop. I added Apache License headers to all of the Gradle, Groovy, and Java sources.
          Hide
          jayunit100 jay vyas added a comment -

          RJ Nowling this is a zip file? did jira do that?

          Show
          jayunit100 jay vyas added a comment - RJ Nowling this is a zip file? did jira do that?
          Hide
          rnowling RJ Nowling added a comment -

          Patch was 24mb because of the data files. Too big for JIRA so I had to zip it up. Just unzip and you'll get a single patch file

          Show
          rnowling RJ Nowling added a comment - Patch was 24mb because of the data files. Too big for JIRA so I had to zip it up. Just unzip and you'll get a single patch file
          Hide
          jayunit100 jay vyas added a comment - - edited

          Hi rj. thanks for finally putting this together !

          • builds clean for me
          • boiler plates look ok

          Just one minor thing we need to fix ....
          build.gradle is out of date in setting up the manifest ./src/main/java/org/apache/bigtop/bigpetstore/datagenerator/cli/Driver.java not attributes 'Main-Class': 'com.github.rnowling.bps.datagenerator.cli.Driver

          since that is just a one liner just make that change right as you commit the code , rather then reattach the whole 8 megabyte patch

          +1 !

          now we can work on the unified gradle build chain for all of BPS .

          Show
          jayunit100 jay vyas added a comment - - edited Hi rj. thanks for finally putting this together ! builds clean for me boiler plates look ok Just one minor thing we need to fix .... build.gradle is out of date in setting up the manifest ./src/main/java/org/apache/bigtop/bigpetstore/datagenerator/cli/Driver.java not attributes 'Main-Class': 'com.github.rnowling.bps.datagenerator.cli.Driver since that is just a one liner just make that change right as you commit the code , rather then reattach the whole 8 megabyte patch +1 ! now we can work on the unified gradle build chain for all of BPS .
          Hide
          rnowling RJ Nowling added a comment -

          Fixed and committed.

          Show
          rnowling RJ Nowling added a comment - Fixed and committed.
          Hide
          jayunit100 jay vyas added a comment -

          awesome. this now consolidates the bigpetstore suite as entirely part of ASF BigTop .

          Show
          jayunit100 jay vyas added a comment - awesome. this now consolidates the bigpetstore suite as entirely part of ASF BigTop .

            People

            • Assignee:
              rnowling RJ Nowling
              Reporter:
              rnowling RJ Nowling
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development