Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1758

Remove redundant property checks from TestHadoopExamples

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: tests
    • Labels:
      None

      Description

      HADOOP_MAPRED_HOME and HADOOP_CONF_DIR env variables are now defined and enforced in appropriate pom files, so we should remove the checks for these properties from TestHadoopExamples.

      1. BIGTOP-1758.patch
        1 kB
        Dasha Boudnik

        Issue Links

          Activity

          Hide
          dasha.boudnik Dasha Boudnik added a comment -

          Closing since this issue was opened after enforcers were added to POMs, and it's necessary to leave the asserts for necessary properties in case this test is run without maven.

          Show
          dasha.boudnik Dasha Boudnik added a comment - Closing since this issue was opened after enforcers were added to POMs, and it's necessary to leave the asserts for necessary properties in case this test is run without maven.
          Hide
          dasha.boudnik Dasha Boudnik added a comment -

          Good point, didn't think of that. I guess let's close this ticket, for now at least. Thanks, Jay!

          Show
          dasha.boudnik Dasha Boudnik added a comment - Good point, didn't think of that. I guess let's close this ticket, for now at least. Thanks, Jay!
          Hide
          jayunit100 jay vyas added a comment -

          +1 to commit if you think its a good idea .... even though the practical benefits of having the redundant check is actually valuable to people running these tests outside of maven.
          ill let you decide , either way, the code looks fine.

          Show
          jayunit100 jay vyas added a comment - +1 to commit if you think its a good idea .... even though the practical benefits of having the redundant check is actually valuable to people running these tests outside of maven. ill let you decide , either way, the code looks fine.
          Hide
          dasha.boudnik Dasha Boudnik added a comment -

          jay vyas, could you please take a look at this if you get a chance?

          Show
          dasha.boudnik Dasha Boudnik added a comment - jay vyas , could you please take a look at this if you get a chance?
          Hide
          dasha.boudnik Dasha Boudnik added a comment -

          Patch attached. Once BIGTOP-1756 is reviewed and committed, same can be done for this.

          Show
          dasha.boudnik Dasha Boudnik added a comment - Patch attached. Once BIGTOP-1756 is reviewed and committed, same can be done for this.

            People

            • Assignee:
              dasha.boudnik Dasha Boudnik
              Reporter:
              dasha.boudnik Dasha Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development