Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 1.0.0
    • Component/s: vm
    • Labels:
      None
    • Environment:

      centos

      Description

      looks like local_yum_repo implementation is broke for vagrant provisioners. looking at it now.

      1. 11.patch
        2 kB
        jay vyas

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jayunit100 opened a pull request:

        https://github.com/apache/bigtop/pull/11

        BIGTOP-1733. Fix local_yum implementation.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jayunit100/bigtop 1733

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/bigtop/pull/11.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #11


        commit 8f986404a2cea5462521ad10586b89b6575a438d
        Author: jayunit100 <jay@apache.org>
        Date: 2015-03-07T23:09:40Z

        BIGTOP-1733. Fix local_yum implementation.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jayunit100 opened a pull request: https://github.com/apache/bigtop/pull/11 BIGTOP-1733 . Fix local_yum implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jayunit100/bigtop 1733 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 8f986404a2cea5462521ad10586b89b6575a438d Author: jayunit100 <jay@apache.org> Date: 2015-03-07T23:09:40Z BIGTOP-1733 . Fix local_yum implementation.
        Hide
        jayunit100 jay vyas added a comment -

        attached same patch as the one in the PR below for formality. please review this so we can get vagrant local testing back up and running

        Show
        jayunit100 jay vyas added a comment - attached same patch as the one in the PR below for formality. please review this so we can get vagrant local testing back up and running
        Hide
        evans_ye Evans Ye added a comment -

        Oh, sorry my bad! I didn't test this thoroughly at vagrant-puppet-vm side.
        Thanks for the quick catch!
        I only have one small comment: we should have messages added in both setup-env-centos.sh and setup-env-debian.sh.

        Show
        evans_ye Evans Ye added a comment - Oh, sorry my bad! I didn't test this thoroughly at vagrant-puppet-vm side. Thanks for the quick catch! I only have one small comment: we should have messages added in both setup-env-centos.sh and setup-env-debian.sh.
        Hide
        jayunit100 jay vyas added a comment -

        updated the patch man. that was easy. https://github.com/apache/bigtop/pull/11.patch

        Show
        jayunit100 jay vyas added a comment - updated the patch man. that was easy. https://github.com/apache/bigtop/pull/11.patch
        Hide
        evans_ye Evans Ye added a comment -

        +1. to the newest patch in comment.

        Show
        evans_ye Evans Ye added a comment - +1. to the newest patch in comment.
        Hide
        jayunit100 jay vyas added a comment -

        anyone want to commit this for me ? I dont have my creds w/ me right now. (Evans/Sean seem to be interested)

        Show
        jayunit100 jay vyas added a comment - anyone want to commit this for me ? I dont have my creds w/ me right now. (Evans/Sean seem to be interested)
        Hide
        evans_ye Evans Ye added a comment -

        Let me do this. I just ran tests for this one and its good. Although the patch needs to have some spaces trimmed, I can do it during committing.

        Show
        evans_ye Evans Ye added a comment - Let me do this. I just ran tests for this one and its good. Although the patch needs to have some spaces trimmed, I can do it during committing.
        Hide
        evans_ye Evans Ye added a comment -

        Committed! Thanks for the catch jay vyas.

        Show
        evans_ye Evans Ye added a comment - Committed! Thanks for the catch jay vyas .
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user b-long commented on the pull request:

        https://github.com/apache/bigtop/pull/11#issuecomment-127687417

        This appears to already be merged. This issue should be closed.

        Show
        githubbot ASF GitHub Bot added a comment - Github user b-long commented on the pull request: https://github.com/apache/bigtop/pull/11#issuecomment-127687417 This appears to already be merged. This issue should be closed.

          People

          • Assignee:
            jayunit100 jay vyas
            Reporter:
            jayunit100 jay vyas
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development