Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1718

add facility for printing out BOM in json format

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: general
    • Labels:
      None

      Description

      It would be useful to have a facility for printing out the BOM in json format. This would allow applications built on top of Bigtop without needing to know how to parse the BOM.

      1. 0002-BIGTOP-1718.patch
        2 kB
        Rob Leidle
      2. BIGTOP-1718.patch
        3 kB
        Rob Leidle
      3. output.txt
        2 kB
        Rob Leidle

        Issue Links

          Activity

          Hide
          rleidle Rob Leidle added a comment - - edited

          see output.txt for sample output

          Show
          rleidle Rob Leidle added a comment - - edited see output.txt for sample output
          Hide
          cos Konstantin Boudnik added a comment -

          Thanks Rob!

          A while back, we had this conversation on the dev@ list (??) to actually make the change to bigtop.mk format and introduce some sort of Groovy DSL. The obvious benefit would be that we can drop the parsing logic completely. And any DSL is in general more human friendly that make macros Anyway, I am very much in favor of getting this in, so it will segway into the bigtop.dsl file later on.

          One comment: there's one whitespace unrelated change in the patch, but it looks very good, besides of that one.

               BOM_map[variable + '_SEED_TAR'] = BOM_map['BUILD_DIR'] + "/$target/tar/" + BOM_map[variable + '_TARBALL_DST']
          -
               BOM_map[variable + '_DOWNLOAD_URL'] =
          
          Show
          cos Konstantin Boudnik added a comment - Thanks Rob! A while back, we had this conversation on the dev@ list (??) to actually make the change to bigtop.mk format and introduce some sort of Groovy DSL. The obvious benefit would be that we can drop the parsing logic completely. And any DSL is in general more human friendly that make macros Anyway, I am very much in favor of getting this in, so it will segway into the bigtop.dsl file later on. One comment: there's one whitespace unrelated change in the patch, but it looks very good, besides of that one. BOM_map[variable + '_SEED_TAR'] = BOM_map['BUILD_DIR'] + "/$target/tar/" + BOM_map[variable + '_TARBALL_DST'] - BOM_map[variable + '_DOWNLOAD_URL'] =
          Hide
          rleidle Rob Leidle added a comment -

          new patch without the extra whitespace attached

          Show
          rleidle Rob Leidle added a comment - new patch without the extra whitespace attached
          Hide
          cos Konstantin Boudnik added a comment -

          +1 will commit it shortly, unless someone has an objection or two...

          BTW, do you want to take a shot at the DSL'ing of the BOM file?

          Show
          cos Konstantin Boudnik added a comment - +1 will commit it shortly, unless someone has an objection or two... BTW, do you want to take a shot at the DSL'ing of the BOM file?
          Hide
          rleidle Rob Leidle added a comment -

          Do you have a link to an example groovy DSL that is similar to what you are looking for?

          Show
          rleidle Rob Leidle added a comment - Do you have a link to an example groovy DSL that is similar to what you are looking for?
          Hide
          cos Konstantin Boudnik added a comment -

          Actually, I don't but we have started this conversation on BIGTOP-1494, so let's continue there.

          Show
          cos Konstantin Boudnik added a comment - Actually, I don't but we have started this conversation on BIGTOP-1494 , so let's continue there.
          Hide
          cos Konstantin Boudnik added a comment -

          Committed and pushed to the master. Thanks Rob!

          Show
          cos Konstantin Boudnik added a comment - Committed and pushed to the master. Thanks Rob!

            People

            • Assignee:
              rleidle Rob Leidle
              Reporter:
              rleidle Rob Leidle
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development