Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1691

Heira site.yaml template needs to have repo uri

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: deployment
    • Labels:
      None

      Description

      It seems that bigtop-deploy/puppet/hieradata/site.yaml is missing repo uri line without which a package manager won't be able to install cluster packages. I think with BIGTOP-1676 the same will be true for apt.

      BTW, can we have multiple URLs specified for the repos? A typical use case would be when you have say release repo and a dev.repo with your experimental stuff. Right now the only way around it is by setting a second repo manually.

        Activity

        Hide
        cos Konstantin Boudnik added a comment -

        A patch to provide a commented out repo_uri entry.
        Also, added to warning about use of TABs and removed seemingly unused #Debian line.

        Show
        cos Konstantin Boudnik added a comment - A patch to provide a commented out repo_uri entry. Also, added to warning about use of TABs and removed seemingly unused #Debian line.
        Hide
        evans_ye Evans Ye added a comment - - edited

        Hey Konstantin Boudnik. I renamed the variable name from bigtop_yumrepo_uri to bigtop_repo_uri in BIGTOP-1676.
        Since we now have yum and apt repo can be auto setup by puppet, the variable name should not specific to yum.

        Or, we can take another strategy, that is to have two kind of repo name can be specified:

        • bigtop_yumrepo_uri
        • bigtop_aptrepo_uri

        Hence we can support mixed OS cluster deployment (for example, centos+debian in one cluster)
        But I think this introduce more complexity and that kind of use case is rare. So I took a simple way in BIGTOP-1676.

        Show
        evans_ye Evans Ye added a comment - - edited Hey Konstantin Boudnik . I renamed the variable name from bigtop_yumrepo_uri to bigtop_repo_uri in BIGTOP-1676 . Since we now have yum and apt repo can be auto setup by puppet, the variable name should not specific to yum. Or, we can take another strategy, that is to have two kind of repo name can be specified: bigtop_yumrepo_uri bigtop_aptrepo_uri Hence we can support mixed OS cluster deployment (for example, centos+debian in one cluster) But I think this introduce more complexity and that kind of use case is rare. So I took a simple way in BIGTOP-1676 .
        Hide
        cos Konstantin Boudnik added a comment -

        Good point. I think I have posted the patch before you commited yours. I will update in a bit.

        Show
        cos Konstantin Boudnik added a comment - Good point. I think I have posted the patch before you commited yours. I will update in a bit.
        Hide
        cos Konstantin Boudnik added a comment -

        Updated. Also, updated the README.md file that was missed during the earlier apt fix.

        Show
        cos Konstantin Boudnik added a comment - Updated. Also, updated the README.md file that was missed during the earlier apt fix.
        Hide
        evans_ye Evans Ye added a comment -

        Looks great. +1

        Show
        evans_ye Evans Ye added a comment - Looks great. +1
        Hide
        evans_ye Evans Ye added a comment -

        I've committed this

        Show
        evans_ye Evans Ye added a comment - I've committed this
        Hide
        cos Konstantin Boudnik added a comment -

        douh... thanks man!

        Show
        cos Konstantin Boudnik added a comment - douh... thanks man!

          People

          • Assignee:
            cos Konstantin Boudnik
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development