Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1685

puppet hadoop: Remove useless use of explicit hiera lookup

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: deployment
    • Labels:
      None

      Description

      Two explicit hiera lookups are left over from reworking the variable
      lookup logic for ssh fencing key parameters. Those can go now.

        Activity

        Hide
        cos Konstantin Boudnik added a comment -

        Done. Pushed to the master.
        Thanks Michael!

        Show
        cos Konstantin Boudnik added a comment - Done. Pushed to the master. Thanks Michael!
        Hide
        cos Konstantin Boudnik added a comment -

        Makes sense. +1
        Let me commit this.

        Show
        cos Konstantin Boudnik added a comment - Makes sense. +1 Let me commit this.
        Hide
        michaelweiser Michael Weiser added a comment -

        Hi Konstantin Boudnik,

        the explicit use of the hiera() function to do the lookup is not necessary since adding them as class parameters with their defaults will do exactly the same. The lookup key used ('hadoop::common_hdfs::...') also directly corresponds to the class namespace. The use of hiera() is left over from when I was not sure how and where the variable values need to be constructed from other values and defaults.

        Show
        michaelweiser Michael Weiser added a comment - Hi Konstantin Boudnik , the explicit use of the hiera() function to do the lookup is not necessary since adding them as class parameters with their defaults will do exactly the same. The lookup key used ('hadoop::common_hdfs::...') also directly corresponds to the class namespace. The use of hiera() is left over from when I was not sure how and where the variable values need to be constructed from other values and defaults.
        Hide
        cos Konstantin Boudnik added a comment -

        Why do you consider this useless?

        Show
        cos Konstantin Boudnik added a comment - Why do you consider this useless?

          People

          • Assignee:
            michaelweiser Michael Weiser
            Reporter:
            michaelweiser Michael Weiser
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development