Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 1.0.0
    • Component/s: tests
    • Labels:
      None

      Description

      allow unpackTestResources to be optional for the test utils... so that smoke-tests can work without needing jars.

      1. BIGTOP-1664.patch
        1 kB
        jay vyas
      2. BIGTOP-1664.patch
        1 kB
        jay vyas
      3. BIGTOP-1664.patch
        1 kB
        jay vyas

        Activity

        Hide
        jayunit100 jay vyas added a comment -

        Dasha Boudnik looks okay? attached patch.

        Show
        jayunit100 jay vyas added a comment - Dasha Boudnik looks okay? attached patch.
        Hide
        cos Konstantin Boudnik added a comment -

        Quick not - the formatting is messed up: indents are 4 instead of 2; catch needs to be on the same line as '}'.
        Sorry for being pedantic.

        Show
        cos Konstantin Boudnik added a comment - Quick not - the formatting is messed up: indents are 4 instead of 2; catch needs to be on the same line as '}'. Sorry for being pedantic.
        Hide
        jayunit100 jay vyas added a comment -

        Ok I can fix that. Any other comments before I submit a final patch?

        Show
        jayunit100 jay vyas added a comment - Ok I can fix that. Any other comments before I submit a final patch?
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        Looks good. +1

        Show
        dasha.boudnik Dasha Boudnik added a comment - Looks good. +1
        Hide
        jayunit100 jay vyas added a comment -

        Okay here we go. looks better now for formatting Konstantin Boudnik ? If so ill push

        Show
        jayunit100 jay vyas added a comment - Okay here we go. looks better now for formatting Konstantin Boudnik ? If so ill push
        Hide
        cos Konstantin Boudnik added a comment -

        Almost, catch need to be like this though

        +    } catch(Throwable t) {
        +      logError("Couldn't unpack resources, you better have resources on your classpath.");
        

        per Java style. Thanks!

        Show
        cos Konstantin Boudnik added a comment - Almost, catch need to be like this though + } catch (Throwable t) { + logError( "Couldn't unpack resources, you better have resources on your classpath." ); per Java style. Thanks!
        Hide
        jayunit100 jay vyas added a comment -

        no prob i don't have my apache creds right now, . reattached ;
        if this patch is good feel free to commit for me !

        Show
        jayunit100 jay vyas added a comment - no prob i don't have my apache creds right now, . reattached ; if this patch is good feel free to commit for me !
        Hide
        jayunit100 jay vyas added a comment -

        or else ill commit later when im home

        Show
        jayunit100 jay vyas added a comment - or else ill commit later when im home
        Hide
        cos Konstantin Boudnik added a comment -

        Looks good. I will commit this. Thanks for fixing!

        Show
        cos Konstantin Boudnik added a comment - Looks good. I will commit this. Thanks for fixing!
        Hide
        cos Konstantin Boudnik added a comment -

        Committed and pushed. Thanks Jay!

        Show
        cos Konstantin Boudnik added a comment - Committed and pushed. Thanks Jay!

          People

          • Assignee:
            Unassigned
            Reporter:
            jayunit100 jay vyas
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development