Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 1.0.0
    • Component/s: tests
    • Labels:
      None

      Description

      build itest w gradle, so that we can call gradle tasks to install it as a local dependency, as part of supporting one single testing framework. See BIGTOP-1608.

      This is the first step, the minimal work necessary to allo gradle based smoke tests to use gradle best itest framework via calling gradle install later those doing publishing of itest jars can finalize the process and test gradle for publishing.

      1. BIGTOP-1621.patch
        4 kB
        Konstantin Boudnik
      2. BIGTOP-1621.patch
        3 kB
        Konstantin Boudnik
      3. BIGTOP-1621.patch
        14 kB
        jay vyas

        Issue Links

          Activity

          Hide
          jayunit100 jay vyas added a comment - - edited

          heres a first stab at making itest easily consumable from other pure gradle components like smoke-tests. Then we can continue on BIGTOP-1608. Konstantin Boudnik and David Capwell ....

          Show
          jayunit100 jay vyas added a comment - - edited heres a first stab at making itest easily consumable from other pure gradle components like smoke-tests . Then we can continue on BIGTOP-1608 . Konstantin Boudnik and David Capwell .... This seems to successfully install itest into my local maven repo if i call gradle install . After this, then in BIGTOP-1608 , we can add project dependency for this guy into smoke-tests , as per this link : http://forums.gradle.org/gradle/topics/reference_external_project_as_dependancy . to test, just apply the patch, and run gradle install and it should do what the old mvn pom task did.
          Hide
          cos Konstantin Boudnik added a comment -

          The gradle part of the build looks ok. I think it'd be nice to have repositories defined in the top-level build, etc., but it's good start - let me play with it.
          I feel somewhat uncomfortable with the surgery performed on the README file. Not everything in there is related to the failure testing. And I don't see a need to have two or more READMEs: let it be one which includes sections on the functionality and build instructions. Better yet - let's hook up the build part to the top-level gradle. Can we do that?

          Show
          cos Konstantin Boudnik added a comment - The gradle part of the build looks ok. I think it'd be nice to have repositories defined in the top-level build, etc., but it's good start - let me play with it. I feel somewhat uncomfortable with the surgery performed on the README file. Not everything in there is related to the failure testing. And I don't see a need to have two or more READMEs: let it be one which includes sections on the functionality and build instructions. Better yet - let's hook up the build part to the top-level gradle. Can we do that?
          Hide
          jayunit100 jay vyas added a comment -

          hiya cos. sounds good to me. re: top level of the build, yes that makes sense, this is just a minimum viable solution, open to others !

          Show
          jayunit100 jay vyas added a comment - hiya cos. sounds good to me. re: top level of the build, yes that makes sense, this is just a minimum viable solution, open to others !
          Hide
          cos Konstantin Boudnik added a comment -

          Here's the patch that adds 'bigtop-itest-framework' as a subproject to the top-level gradle build.

          I have removed the changes in README files (for now); as well I don't think adding 'vars.properties' file in this patch is a good idea for two reasons:

          1. it isn't in the scope of the patch
          2. the use of vars.properties is mis-documented and needs to be updated in a separate JIRA.

          I think this approach of creating build layout should work very well (and more work needs to be done for deployment, etc.), but I'd love to hear others opinions.

          Dasha Boudnik, could you please open a ticket and update the bigtop-test-framework/README file accordingly to the latest failure injection code, please?

          Show
          cos Konstantin Boudnik added a comment - Here's the patch that adds 'bigtop-itest-framework' as a subproject to the top-level gradle build. I have removed the changes in README files (for now); as well I don't think adding 'vars.properties' file in this patch is a good idea for two reasons: it isn't in the scope of the patch the use of vars.properties is mis-documented and needs to be updated in a separate JIRA. I think this approach of creating build layout should work very well (and more work needs to be done for deployment, etc.), but I'd love to hear others opinions. Dasha Boudnik , could you please open a ticket and update the bigtop-test-framework/README file accordingly to the latest failure injection code, please?
          Hide
          cos Konstantin Boudnik added a comment -

          packages.gradle and top-level build.gradle should use rootDir reference otherwise it's impossible to start the build from a subproject.

          Show
          cos Konstantin Boudnik added a comment - packages.gradle and top-level build.gradle should use rootDir reference otherwise it's impossible to start the build from a subproject.
          Hide
          jayunit100 jay vyas added a comment - - edited

          hi cos. thanks for this. im trying to think how i can borrow this snippet to update smoke-tests to run from root gradle file as well.

          1) can you explain what the point of these two lines are ?

          +
          +include 'bigtop-test-framework', 'bigtop-tests:smoke-tests'
          +
          +project(":bigtop-test-framework").name = 'itest-common'
          

          Also, did you need a review of this patch>? Or just a work in progress ?

          2) I still see

          76 task installiTest(type:Exec) {
           77   workingDir "."
           78   commandLine 'mvn clean install -f bigtop-test-framework/pom.xml -DskipTests'.split(" ")
           79 }
          

          Can we eliminate or at least deprecate that task, now that itest can build via gradle?

          Show
          jayunit100 jay vyas added a comment - - edited hi cos. thanks for this. im trying to think how i can borrow this snippet to update smoke-tests to run from root gradle file as well. 1) can you explain what the point of these two lines are ? + +include 'bigtop-test-framework', 'bigtop-tests:smoke-tests' + +project(":bigtop-test-framework").name = 'itest-common' Also, did you need a review of this patch>? Or just a work in progress ? 2) I still see 76 task installiTest(type:Exec) { 77 workingDir "." 78 commandLine 'mvn clean install -f bigtop-test-framework/pom.xml -DskipTests'.split(" ") 79 } Can we eliminate or at least deprecate that task, now that itest can build via gradle?
          Hide
          cos Konstantin Boudnik added a comment -

          This is how gradle pulls in subprojects (1st line); in the second one I declare a module name that differs from the module's directory name.
          As for review: the objective of the JIRA is covered, I think. We can take further advancements elsewhere... What do you think?

          Show
          cos Konstantin Boudnik added a comment - This is how gradle pulls in subprojects (1st line); in the second one I declare a module name that differs from the module's directory name. As for review: the objective of the JIRA is covered, I think. We can take further advancements elsewhere... What do you think?
          Hide
          jayunit100 jay vyas added a comment -

          hola ... i just updated my question above can you respond to (2) ...

          Show
          jayunit100 jay vyas added a comment - hola ... i just updated my question above can you respond to (2) ...
          Hide
          jayunit100 jay vyas added a comment -

          +1 to commit, i did a test it seems to work.
          please create a jira to deprecate the maven dependency from itest when you commit thanks !

          Show
          jayunit100 jay vyas added a comment - +1 to commit, i did a test it seems to work. please create a jira to deprecate the maven dependency from itest when you commit thanks !
          Hide
          cos Konstantin Boudnik added a comment -

          Pushed

          Show
          cos Konstantin Boudnik added a comment - Pushed

            People

            • Assignee:
              cos Konstantin Boudnik
              Reporter:
              jayunit100 jay vyas
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development