Details

      Description

      Looks like we have a couple of tests failing for a long time now.

      • ClusterFailuresTest.testNetworkShutdown
      • ClusterFailuresTest.testServiceRestart

      For more info look at
      https://builds.apache.org/job/Bigtop-trunk-iTest/org.apache.bigtop.itest$itest-common/1886/testReport/

      1. BIGTOP-1559.patch
        13 kB
        Dasha Boudnik
      2. BIGTOP-1559.patch
        12 kB
        Dasha Boudnik
      3. BIGTOP-1559.patch
        12 kB
        Dasha Boudnik

        Issue Links

          Activity

          Hide
          cos Konstantin Boudnik added a comment -

          Tests are failing with the following errors:

          • ClusterFailuresTest.testNetworkShutdown
            No ping to null, which is used for network failures test:. Expression: this.isRemoteHostReachable()
            
            Stacktrace
            
            java.lang.AssertionError: No ping to null, which is used for network failures test:. Expression: this.isRemoteHostReachable()
            	at org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:401)
            	at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:655)
            	at org.apache.bigtop.itest.failures.ClusterFailuresTest.testNetworkShutdown(ClusterFailuresTest.groovy:129)
            
          • ClusterFailuresTest.testServiceRestart
            cron service isn't running before the test:. Expression: this.isCronRunning()
            
            Stacktrace
            
            java.lang.AssertionError: cron service isn't running before the test:. Expression: this.isCronRunning()
            	at org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:401)
            	at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:655)
            	at org.apache.bigtop.itest.failures.ClusterFailuresTest.testServiceRestart(ClusterFailuresTest.groovy:59)
            
          Show
          cos Konstantin Boudnik added a comment - Tests are failing with the following errors: ClusterFailuresTest.testNetworkShutdown No ping to null , which is used for network failures test:. Expression: this .isRemoteHostReachable() Stacktrace java.lang.AssertionError: No ping to null , which is used for network failures test:. Expression: this .isRemoteHostReachable() at org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:401) at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:655) at org.apache.bigtop.itest.failures.ClusterFailuresTest.testNetworkShutdown(ClusterFailuresTest.groovy:129) ClusterFailuresTest.testServiceRestart cron service isn't running before the test:. Expression: this .isCronRunning() Stacktrace java.lang.AssertionError: cron service isn't running before the test:. Expression: this .isCronRunning() at org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:401) at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:655) at org.apache.bigtop.itest.failures.ClusterFailuresTest.testServiceRestart(ClusterFailuresTest.groovy:59)
          Hide
          cos Konstantin Boudnik added a comment -

          I think the main problem here is that the failure tests shouldn't be unit tests in the first place. And more importantly, they shouldn't be a part of iTest unit tests. Let's move it out into a network failure integration tests or something.

          Show
          cos Konstantin Boudnik added a comment - I think the main problem here is that the failure tests shouldn't be unit tests in the first place. And more importantly, they shouldn't be a part of iTest unit tests. Let's move it out into a network failure integration tests or something.
          Hide
          cos Konstantin Boudnik added a comment -

          Dasha Boudnik, could you please take a look?

          Show
          cos Konstantin Boudnik added a comment - Dasha Boudnik , could you please take a look?
          Hide
          dasha.boudnik Dasha Boudnik added a comment -

          ClusterFailuresTest was made into an integration test and excluded from unit tests. So, now it's not run as part of the unit test cycle. BIGTOP-1590 should take care of that.

          Show
          dasha.boudnik Dasha Boudnik added a comment - ClusterFailuresTest was made into an integration test and excluded from unit tests. So, now it's not run as part of the unit test cycle. BIGTOP-1590 should take care of that.
          Hide
          cos Konstantin Boudnik added a comment -

          I see that the test is getting excluded from the run now. Please remove the comment saying "<!-- Tests which need to be fixed -->" and the patch is good

          Show
          cos Konstantin Boudnik added a comment - I see that the test is getting excluded from the run now. Please remove the comment saying "<!-- Tests which need to be fixed -->" and the patch is good
          Hide
          cos Konstantin Boudnik added a comment -

          +1 will commit it shortly

          Show
          cos Konstantin Boudnik added a comment - +1 will commit it shortly
          Hide
          cos Konstantin Boudnik added a comment -

          Pushed to the master. Thanks Dasha!

          Show
          cos Konstantin Boudnik added a comment - Pushed to the master. Thanks Dasha!

            People

            • Assignee:
              dasha.boudnik Dasha Boudnik
              Reporter:
              cos Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development