Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: documentation, vm
    • Labels:
      None

      Description

      I noticed a couple files nobody (i think) is using

      1) DEVNOTES : A file just floating in the top level directory.
      2) bigtop-deploy/vm/boxgrinder recipes. Are we planning to continue w/ boxgrinder, and are we supporting it ?
      3) bigtop-deploy/vm/vagrant/ (non puppet recipe)

      shall we delete these ?
      or are people using them?

      1. BIGTOP-1556.patch
        10 kB
        Dasha Boudnik
      2. BIGTOP-1556.patch
        16 kB
        Dasha Boudnik

        Activity

        Hide
        cos Konstantin Boudnik added a comment -

        Agree on boxgrinder, jay vyas told me that the same same functionality can be achieved via Vagrant. Besides, who needs a VM if you can get a ready to go docker container?

        Show
        cos Konstantin Boudnik added a comment - Agree on boxgrinder, jay vyas told me that the same same functionality can be achieved via Vagrant. Besides, who needs a VM if you can get a ready to go docker container?
        Hide
        cos Konstantin Boudnik added a comment -

        I also am thinking of getting rid of bigtop-deploy/live-cd. Is anyone using it?

        Show
        cos Konstantin Boudnik added a comment - I also am thinking of getting rid of bigtop-deploy/live-cd . Is anyone using it?
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        This only includes the three points outlined in the decription, since it's only been two days since deleting live-cd has been suggested and maybe someone will reply... Or should I take it out at this point?

        Show
        dasha.boudnik Dasha Boudnik added a comment - This only includes the three points outlined in the decription, since it's only been two days since deleting live-cd has been suggested and maybe someone will reply... Or should I take it out at this point?
        Hide
        cos Konstantin Boudnik added a comment -

        could you please also include the output of git status so it is clear what's being removed? Thanks

        Show
        cos Konstantin Boudnik added a comment - could you please also include the output of git status so it is clear what's being removed? Thanks
        Hide
        dasha.boudnik Dasha Boudnik added a comment - - edited
        deleted:    DEVNOTES
        deleted:    bigtop-deploy/vm/boxgrinder/bigtop-init-hdfs
        deleted:    bigtop-deploy/vm/boxgrinder/bigtop_hadoop.appl
        deleted:    bigtop-deploy/vm/vagrant/README
        deleted:    bigtop-deploy/vm/vagrant/Vagrantfile
        deleted:    bigtop-deploy/vm/vagrant/provision.sh
        Show
        dasha.boudnik Dasha Boudnik added a comment - - edited deleted: DEVNOTES deleted: bigtop-deploy/vm/boxgrinder/bigtop-init-hdfs deleted: bigtop-deploy/vm/boxgrinder/bigtop_hadoop.appl deleted: bigtop-deploy/vm/vagrant/README deleted: bigtop-deploy/vm/vagrant/Vagrantfile deleted: bigtop-deploy/vm/vagrant/provision.sh
        Hide
        cos Konstantin Boudnik added a comment -

        I'd say let's add live-cd into the patch - if a reviewer would feel strongly about we always can exclude from the scope of this JIRA.

        Show
        cos Konstantin Boudnik added a comment - I'd say let's add live-cd into the patch - if a reviewer would feel strongly about we always can exclude from the scope of this JIRA.
        Hide
        dasha.boudnik Dasha Boudnik added a comment -
        deleted:    DEVNOTES
        deleted:    bigtop-deploy/live-cd/apache-bigtop.ks
        deleted:    bigtop-deploy/vm/boxgrinder/bigtop-init-hdfs
        deleted:    bigtop-deploy/vm/boxgrinder/bigtop_hadoop.appl
        deleted:    bigtop-deploy/vm/vagrant/README
        deleted:    bigtop-deploy/vm/vagrant/Vagrantfile
        deleted:    bigtop-deploy/vm/vagrant/provision.sh
        Show
        dasha.boudnik Dasha Boudnik added a comment - deleted: DEVNOTES deleted: bigtop-deploy/live-cd/apache-bigtop.ks deleted: bigtop-deploy/vm/boxgrinder/bigtop-init-hdfs deleted: bigtop-deploy/vm/boxgrinder/bigtop_hadoop.appl deleted: bigtop-deploy/vm/vagrant/README deleted: bigtop-deploy/vm/vagrant/Vagrantfile deleted: bigtop-deploy/vm/vagrant/provision.sh
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        There's a mention of DEVNOTES in install-flume.sh. Should we take out that line?

        # Take out useless things or we've installed elsewhere
        for x in flume-ng-* \
                  .gitignore \
                  conf \
                  pom.xml \
                  CHANGELOG \
                  DEVNOTES \
                  DISCLAIMER \
                  LICENSE \
                  NOTICE \
                  README \
                  RELEASE-NOTES \
                  bin/ia64 \
                  bin/amd64; do
          rm -rf ${PREFIX}/$LIB_DIR/$x 
        done
        Show
        dasha.boudnik Dasha Boudnik added a comment - There's a mention of DEVNOTES in install-flume.sh. Should we take out that line? # Take out useless things or we've installed elsewhere for x in flume-ng-* \ .gitignore \ conf \ pom.xml \ CHANGELOG \ DEVNOTES \ DISCLAIMER \ LICENSE \ NOTICE \ README \ RELEASE-NOTES \ bin/ia64 \ bin/amd64; do rm -rf ${PREFIX}/$LIB_DIR/$x done
        Hide
        cos Konstantin Boudnik added a comment -

        This is a flume specific DEVNOTES - don't worry about it.

        Show
        cos Konstantin Boudnik added a comment - This is a flume specific DEVNOTES - don't worry about it.
        Hide
        jayunit100 jay vyas added a comment -

        +1, looks mostly like removal of old vagrant recipe and boxgrinder stuffs.

        Show
        jayunit100 jay vyas added a comment - +1, looks mostly like removal of old vagrant recipe and boxgrinder stuffs.
        Hide
        cos Konstantin Boudnik added a comment -

        I will commit it in a bit once my auth. is reset (again, dammit).

        Dasha Boudnik, for the future - could you please generate the patches using git format-patch HEAD~1 as described here https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute

        Show
        cos Konstantin Boudnik added a comment - I will commit it in a bit once my auth. is reset (again, dammit). Dasha Boudnik , for the future - could you please generate the patches using git format-patch HEAD~1 as described here https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
        Hide
        cos Konstantin Boudnik added a comment -

        Committed and pushed to master. Thanks Dasha!

        Show
        cos Konstantin Boudnik added a comment - Committed and pushed to master. Thanks Dasha!

          People

          • Assignee:
            dasha.boudnik Dasha Boudnik
            Reporter:
            jayunit100 jay vyas
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development