Bigtop
  1. Bigtop
  2. BIGTOP-1357

Get rid of HCatalog packaging code

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: debian, rpm
    • Labels:
      None

      Description

      HCatalog is bundled with Hive in the newer releases of hive. Consequently, it's packaging code should reside in Hive's packaging directories (and it already does).

      Consequently, we are not using https://github.com/apache/bigtop/tree/master/bigtop-packages/src/common/hcatalog
      and the corresponding locations in rpm and deb directories which used to package HCatalog before it was a part of hive.

      So, we should get rid of those directories. Also, we should check in bigtop.mk and make sure no references to building HCatalog remain. The only way, we should be able to build HCatalog should be via Hive.

        Activity

        Hide
        Roman Shaposhnik added a comment -

        +1 to the idea.

        Show
        Roman Shaposhnik added a comment - +1 to the idea.
        Hide
        Giridharan Kesavan added a comment -

        Roman Shaposhnik
        Could you pls help assign this jira to me?

        Show
        Giridharan Kesavan added a comment - Roman Shaposhnik Could you pls help assign this jira to me?
        Hide
        Konstantin Boudnik added a comment -

        to 0.9.0 as no progress seems to be made so far.

        Show
        Konstantin Boudnik added a comment - to 0.9.0 as no progress seems to be made so far.
        Hide
        Giridharan Kesavan added a comment -

        this patch remove hcatalog pkg related changes

        Show
        Giridharan Kesavan added a comment - this patch remove hcatalog pkg related changes
        Hide
        Peter Linnell added a comment - - edited

        Giridharan Kesavan The patch looks good and I think it should definitely be part of 0.9.0. My question is do we need to change anything in the existing hive packaging ? Sorry for being a stickler, but would like to avoid unexpected breakage in 0.9.x

        Thanks!

        Show
        Peter Linnell added a comment - - edited Giridharan Kesavan The patch looks good and I think it should definitely be part of 0.9.0. My question is do we need to change anything in the existing hive packaging ? Sorry for being a stickler, but would like to avoid unexpected breakage in 0.9.x Thanks!
        Hide
        Mark Grover added a comment -

        Peter, no change in hive packaging required since it already contains hcatalog packaging already: https://github.com/apache/bigtop/blob/master/bigtop-packages/src/rpm/hive/SPECS/hive.spec#L161

        The code being removed by this patch is just dead code.

        +1

        Show
        Mark Grover added a comment - Peter, no change in hive packaging required since it already contains hcatalog packaging already: https://github.com/apache/bigtop/blob/master/bigtop-packages/src/rpm/hive/SPECS/hive.spec#L161 The code being removed by this patch is just dead code. +1
        Hide
        Peter Linnell added a comment -

        Thanks Mark for the clarification. +1 then as well.

        Show
        Peter Linnell added a comment - Thanks Mark for the clarification. +1 then as well.
        Hide
        Mark Grover added a comment -

        Committed. Thanks, Giri!

        Show
        Mark Grover added a comment - Committed. Thanks, Giri!

          People

          • Assignee:
            Giridharan Kesavan
            Reporter:
            Mark Grover
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development