Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.9.0
    • Component/s: debian
    • Labels:
      None

      Description

      We currently maintain this very hard to maintain list for all jars shipped in hive package:
      https://github.com/apache/bigtop/blob/master/bigtop-packages/src/deb/hive/hive.install

      This is done because hive-jdbc package needs to include some set of core hive jars and there is no real good way in debian land to say something like include these 5 jars in /usr/lib/hive/lib in hive-jdbc package and include everything else in hive package (btw, rpm does. See here: https://github.com/apache/bigtop/blob/master/bigtop-packages/src/rpm/hive/SPECS/hive.spec#L336)

      But, given that this is pretty unmaintainable, we should come up with something better and populate this list on the fly. Something like listing contents of what all is present in HIVE_HOME/lib and getting rid explicitly of the jars we bundle in hive-jdbc package seems like a good option.

      1. BIGTOP-1356.patch
        5 kB
        Julien Eid
      2. BIGTOP-1356.patch
        5 kB
        Julien Eid
      3. BIGTOP-1356.patch
        6 kB
        Julien Eid

        Activity

        Hide
        Julien Eid added a comment -

        I would like to be assigned to this ticket.

        Show
        Julien Eid added a comment - I would like to be assigned to this ticket.
        Hide
        Mark Grover added a comment -

        Great!

        I am unable to assign the JIRA to you because I don't seem to have the karma to add you to JIRA's developers list.

        Roman Shaposhnik/Konstantin Boudnik: can you please add Julien to the list?

        Also, any chance I can get the privilege so I don't have to bother you over and over again?

        Show
        Mark Grover added a comment - Great! I am unable to assign the JIRA to you because I don't seem to have the karma to add you to JIRA's developers list. Roman Shaposhnik / Konstantin Boudnik : can you please add Julien to the list? Also, any chance I can get the privilege so I don't have to bother you over and over again?
        Hide
        Julien Eid added a comment -

        Made a package with this patch and from master and diff'd their package contents and no files in the files list were missing, so it looks pretty good! There is a hive.install.include that includes those files and directories and then we list all the libs in /usr/lib/hive/lib and exclude the ones specified in sub packages.

        Show
        Julien Eid added a comment - Made a package with this patch and from master and diff'd their package contents and no files in the files list were missing, so it looks pretty good! There is a hive.install.include that includes those files and directories and then we list all the libs in /usr/lib/hive/lib and exclude the ones specified in sub packages.
        Hide
        Roman Shaposhnik added a comment -

        Great work, [~julien.eid]! One small nit, can you make the script just output to stdout and do the re-direction in rules?

        Show
        Roman Shaposhnik added a comment - Great work, [~julien.eid] ! One small nit, can you make the script just output to stdout and do the re-direction in rules?
        Hide
        Julien Eid added a comment -

        Added redirection

        Show
        Julien Eid added a comment - Added redirection
        Hide
        Sean Mackrory added a comment -

        +1 technically. Can we also just reword the initial comments to make them cleaner and fix some of the whitespace in get_excludes? Then I'll gladly commit this! (Also - tested on Fedora - looks good)

        Show
        Sean Mackrory added a comment - +1 technically. Can we also just reword the initial comments to make them cleaner and fix some of the whitespace in get_excludes? Then I'll gladly commit this! (Also - tested on Fedora - looks good)
        Hide
        Julien Eid added a comment -

        Changed according to Sean's comments.

        Show
        Julien Eid added a comment - Changed according to Sean's comments.
        Hide
        Sean Mackrory added a comment -

        +1 and committed. For some reason that I can't see, it was unable to apply your patch cleanly directly, but I added your name to the commit message.

        Show
        Sean Mackrory added a comment - +1 and committed. For some reason that I can't see, it was unable to apply your patch cleanly directly, but I added your name to the commit message.

          People

          • Assignee:
            Julien Eid
            Reporter:
            Mark Grover
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development